Comment out JSR-353 ("old" JSONP) -- doesn't work with 3.0

Author: cowtowncoder

pom.xml

@@ -162,10 +162,6 @@
       <groupId>tools.jackson.datatype</groupId>
       <artifactId>jackson-datatype-jsr310</artifactId>
     </dependency>
-    <dependency>
-      <groupId>tools.jackson.datatype</groupId>
-      <artifactId>jackson-datatype-jsr353</artifactId>
-    </dependency>
     <!-- Part of jackson-databind in 3.0: 
     <dependency>
       <groupId>tools.jackson.datatype</groupId>
@@ -175,12 +171,6 @@
 
     <!-- JSONP/JSR-353 datatype modules will need actual JSON-P provider impls:
      -->
-    <!-- "old" jsr-353: -->
-    <dependency>
-        <groupId>org.glassfish</groupId>
-        <artifactId>javax.json</artifactId>
-        <version>1.1.4</version>
-    </dependency>
     <!--  "new" jakarta jsonp: -->
     <dependency>
         <groupId>jakarta.json</groupId>

src/main/java/module-info.java

@@ -27,7 +27,8 @@
     requires transitive tools.jackson.datatype.joda;
     requires transitive tools.jackson.datatype.javatime;
     requires transitive tools.jackson.datatype.jsonp;
-    requires transitive tools.jackson.datatype.jsr353;
+    // No more supported on 3.0
+    //requires transitive tools.jackson.datatype.jsr353;
     requires transitive tools.jackson.datatype.guava;
 
     // Other Jackson components
@@ -39,7 +40,6 @@
     // 3rd party
     requires transitive com.google.common;
     requires transitive jakarta.json; // new JSONP
-    requires transitive java.json; // old JSONP
     requires transitive kotlin.stdlib;
     requires transitive org.immutables.value;
     requires transitive org.joda.time;

src/main/java/tools/jackson/integtest/base/Base.java

@@ -0,0 +1,9 @@
+package tools.jackson.integtest.base;
+
+/**
+ * Placeholder/bogus class needed to provide {@code module-info.java} file
+ * for dependencies for tests.
+ */
+public class Base {
+    
+}

src/test/java/tools/jackson/integtest/dt/jsonp/JavaxOldJsonpTest.java

@@ -2,34 +2,12 @@
 
 import org.junit.jupiter.api.Test;
 
-import javax.json.JsonArray;
-import javax.json.JsonNumber;
-import javax.json.JsonString;
-import javax.json.JsonValue;
-
-import tools.jackson.databind.ObjectMapper;
-import tools.jackson.datatype.jsr353.JSR353Module;
-
 import tools.jackson.integtest.BaseTest;
 
-import static org.junit.jupiter.api.Assertions.*;
-
+// 04-Feb-2025, tatu: Old JSR 353 is not supported well with JPMS,
+//   cannot really test. Left a placeholder for now.
 public class JavaxOldJsonpTest extends BaseTest
 {
     @Test
-    public void testSimpleDeser() throws Exception
-    {
-        final ObjectMapper mapper = jsonMapperBuilder()
-                .addModule(new JSR353Module())
-                .build();
-
-        final String JSON = "[1,true,\"foo\"]";
-        JsonValue v = mapper.readValue(JSON, JsonValue.class);
-        assertTrue(v instanceof JsonArray);
-        JsonArray a = (JsonArray) v;
-        assertEquals(3, a.size());
-        assertTrue(a.get(0) instanceof JsonNumber);
-        assertSame(JsonValue.TRUE, a.get(1));
-        assertTrue(a.get(2) instanceof JsonString);
-    }
+    public void testNothing() { }
 }

src/test/java/tools/jackson/integtest/immutables/ImmutablesTypeSerializationTest.java

@@ -20,22 +20,22 @@ public class ImmutablesTypeSerializationTest
     @Value.Immutable
     @JsonDeserialize(as = ImmutableAccount.class)
     @JsonSerialize(as = ImmutableAccount.class)
-    interface Account {
+    public interface Account {
         Long getId();
         String getName();
     }
 
     @Value.Immutable
     @JsonDeserialize(as = ImmutableKey.class)
     @JsonSerialize(as = ImmutableKey.class)
-    interface Key<T> {
+    public interface Key<T> {
         T getId();
     }
 
     @Value.Immutable
     @JsonDeserialize(as = ImmutableEntry.class)
     @JsonSerialize(as = ImmutableEntry.class)
-    interface Entry<K, V> {
+    public interface Entry<K, V> {
         K getKey();
         V getValue();
     }