Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect culling with More Culling installed #479

Closed
StockiesLad opened this issue Aug 2, 2022 · 8 comments
Closed

Incorrect culling with More Culling installed #479

StockiesLad opened this issue Aug 2, 2022 · 8 comments
Assignees
Labels
area: compatibility Issue only happens when other mods are present type: bug Issue where something isn't working

Comments

@StockiesLad
Copy link

Describe the Bug

it doesnt render the blockface that it is sitting on, despite being a transparent

Reproduction Steps

1.use this modpack: https://www.technicpack.net/modpack/the-limit-reborn-1181.1905659
2.update create (remove addons that are outdated)
3.issue
...

Expected Result

To render normally

Screenshots and Videos

Uploading image.png…

Crash Report or Log

https://gist.github.com/FluffyBumblebees/3fefc9ab56db82adfc5dd53a888f95af

Operating System

Win 10

Mod Version

0.5.0c

Minecraft Version

1.18.2

Other Mods

Listed on the modpack page

Additional Context

it's not shaders, tested without it

@StockiesLad StockiesLad added the type: bug Issue where something isn't working label Aug 2, 2022
@github-actions github-actions bot added the 1.18 label Aug 2, 2022
@TropheusJ
Copy link
Member

mod incompatibility, try to narrow it down

@StockiesLad
Copy link
Author

Ok, I'd guess indium/sodium but I'll test once create additions is updated (so that my modpack doesnt break)

@StockiesLad
Copy link
Author

Add this to low priority for now

@StockiesLad StockiesLad changed the title Rendering issue when track is above blcok Rendering issue when track is above block Aug 4, 2022
@StockiesLad
Copy link
Author

It is more culling

@StockiesLad StockiesLad changed the title Rendering issue when track is above block Rendering issue when track is above block with more culling installed Aug 4, 2022
@StockiesLad
Copy link
Author

image

@FxMorin
Copy link

FxMorin commented Aug 4, 2022

Ok so this is due to the culling shape of the track being a flat box. The call to getOcclusionShape() returns the culling shape of the track, its not used so getShape() is used instead. As you can see here it then gets the correct voxel for this track.
The Voxel leads to here where you can see its just a flat box.
This is not the correct culling shape based on what the track looks like.

There are multiple ways to fix this:

  1. Use the correct culling shape. This can help other rails next to the rail cull!
  2. Use the block tag: moreculling:dont_cull
  3. Use the moreculling API to set cantCullAgainst() to prevent culling against the block while still allowing the rails to cull themselves against other blocks

If you do option 3, you can also use the API to set customShouldDrawFace() so that the rails cull against themselves.
Otherwise please set isSideInvisible to do that.

With a long rail setup, culling these faces can really help out

@StockiesLad
Copy link
Author

Ok so this is due to the culling shape of the track being a flat box. The call to getOcclusionShape() returns the culling shape of the track, its not used so getShape() is used instead. As you can see here it then gets the correct voxel for this track. The Voxel leads to here where you can see its just a flat box. This is not the correct culling shape based on what the track looks like.

There are multiple ways to fix this:

  1. Use the correct culling shape. This can help other rails next to the rail cull!
  2. Use the block tag: moreculling:dont_cull
  3. Use the moreculling API to set cantCullAgainst() to prevent culling against the block while still allowing the rails to cull themselves against other blocks

If you do option 3, you can also use the API to set customShouldDrawFace() so that the rails cull against themselves. Otherwise please set isSideInvisible to do that.

With a long rail setup, culling these faces can really help out

I'll KJS the blocktag for a temp fix

@TropheusJ TropheusJ changed the title Rendering issue when track is above block with more culling installed Incorrect culling with More Culling installed Dec 25, 2022
@github-actions github-actions bot added the 1.19 label Dec 25, 2022
@TropheusJ TropheusJ added the area: compatibility Issue only happens when other mods are present label Feb 2, 2023
@IThundxr IThundxr self-assigned this Aug 24, 2024
@IThundxr
Copy link
Member

Seems to already be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compatibility Issue only happens when other mods are present type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants