Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REI Oversights #297

Closed
Notenoughmail opened this issue May 18, 2022 · 5 comments
Closed

REI Oversights #297

Notenoughmail opened this issue May 18, 2022 · 5 comments
Labels
type: bug Issue where something isn't working

Comments

@Notenoughmail
Copy link

Describe the Bug

For splashing (and possibly other fan processing types as well) the output percentage does not display in the tooltip, but the background is still checkerboard to indicate it is a percentage.

In addition, for splashing recipes, REI does not correctly support up to six recipes, like JEI does on Forge

Reproduction Steps

  1. Create a splashing recipe via datapacks/kubejs/etc. with more than three outputs and a chance output
  2. Observe the recipe via REI

Expected Result

The hover tooltip for outputs should have their percent chance of output shown and recipes with more than three outputs should rearrange them to be two columns next to each other

Screenshots and Videos

As seen in my testing:
bug
Sequenced assembly correctly displaying percent chance output on hover:
no_bug
Simi's statement and demonstration of expected behavior:
dev

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.4.1

Minecraft Version

1.18.2

Other Mods

No response

Additional Context

Great job on getting the port done! Been enjoying it with some Fabric mods I haven't used before and am having a blast!

@Notenoughmail Notenoughmail added the type: bug Issue where something isn't working label May 18, 2022
@github-actions github-actions bot added the 1.18 label May 18, 2022
@michlbro
Copy link

michlbro commented May 18, 2022

For the output percentage issue, I believe it has something to do with REI (Someone has made this issue here)

@Notenoughmail
Copy link
Author

Update: after installing (and then removing b/c crashes) some mods, the percentages show up again for some reason

@Notenoughmail
Copy link
Author

Update 2: The percentages are only shown for some recipes
https://youtu.be/0xUQ5rlIjIA

@michlbro
Copy link

michlbro commented May 21, 2022

Yep, if you click on the hyper link someone has said its not just Create that has this problem but also tinkers construct.

Edit: On REI’s github page, it says that this will be fixed in the next release.

@TropheusJ
Copy link
Member

see #1616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants