Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MDN shims instead of edited ones? #18

Open
ff6347 opened this issue Nov 4, 2019 · 3 comments
Open

Use MDN shims instead of edited ones? #18

ff6347 opened this issue Nov 4, 2019 · 3 comments

Comments

@ff6347
Copy link
Member

ff6347 commented Nov 4, 2019

@EugenTepin went through the process of adapting all shims to the quirks of Extendscript.

  • Should we stay with these (vote 👍 )
  • Should we roll back to the ones from MDN (vote 👎 )

What are the pros and cons for both sides?

@lumenn
Copy link
Member

lumenn commented Nov 4, 2019

I wonder if there is need to update them.
Did those changed so much, that it's neccesary ?

@ff6347
Copy link
Member Author

ff6347 commented Nov 4, 2019

Did those changed so much, that it's neccesary ?

If we want to follow the plan to run tests on local env and on CI yes. If we only test local it can stay that way.

@lumenn
Copy link
Member

lumenn commented Nov 4, 2019

Then I'd say, lets do it as it should be done for todays standards with CI server, it will be more work, but benefits of CI are clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants