Fix autocomplete in exec and act commands

Author: sembrestels

packages/evmcrispr/src/modules/aragonos/commands/act.ts

@@ -1,3 +1,4 @@
+import type { AbiFunction } from "viem";
 import { isAddress } from "viem";
 
 import type { AbiBinding, ICommand } from "../../../types";
@@ -12,7 +13,6 @@ import {
   checkArgsLength,
   encodeAction,
   fetchAbi,
-  getFunctionFragment,
   insideNodeLine,
   interpretNodeSync,
   tryAndCacheNotFound,
@@ -85,16 +85,18 @@ export const act: ICommand<AragonOS> = {
         if (!abi) {
           return [];
         }
-
         const functions = abi
           // Only consider functions that change state
           .filter(
-            (item) =>
+            (item): item is AbiFunction =>
               item.type === "function" &&
               (item.stateMutability === "nonpayable" ||
                 item.stateMutability === "payable"),
           )
-          .map(getFunctionFragment);
+          .map(
+            (func: AbiFunction) =>
+              `${func.name}(${func.inputs.map((input) => input.type).join(",")})`,
+          );
         return functions;
       }
       default: {

packages/evmcrispr/src/modules/std/commands/exec.ts

@@ -1,3 +1,4 @@
+import type { AbiFunction } from "viem";
 import { getAbiItem, isAddress } from "viem";
 
 import { BindingsSpace } from "../../../types";
@@ -145,7 +146,7 @@ export const exec: ICommand<Std> = {
           nodeArgs[0].type === "HelperFunctionExpression" &&
           (nodeArgs[0] as HelperFunctionNode).name === "token"
             ? erc20ABI
-            : (function () {
+            : (() => {
                 const targetAddress = interpretNodeSync(
                   nodeArgs[0],
                   bindingsManager,
@@ -162,12 +163,15 @@ export const exec: ICommand<Std> = {
         const functions = abi
           // Only consider functions that change state
           .filter(
-            (item) =>
+            (item): item is AbiFunction =>
               item.type === "function" &&
               (item.stateMutability === "nonpayable" ||
                 item.stateMutability === "payable"),
           )
-          .map(getFunctionFragment);
+          .map(
+            (func: AbiFunction) =>
+              `${func.name}(${func.inputs.map((input) => input.type).join(",")})`,
+          );
         return functions;
       }
       default: {

packages/evmcrispr/src/utils/web3.ts

@@ -10,7 +10,7 @@ export const SIGNATURE_REGEX =
 export const toDecimals = (amount: number | string, decimals = 18): bigint => {
   const [integer, decimal] = String(amount).split(".");
   return BigInt(
-    (integer != "0" ? integer : "") + (decimal || "").padEnd(decimals, "0") ||
+    (integer !== "0" ? integer : "") + (decimal || "").padEnd(decimals, "0") ||
       "0",
   );
 };
@@ -22,7 +22,6 @@ export function addressesEqual(first: Address, second: Address): boolean {
 export function getFunctionFragment(func: AbiItem | undefined) {
   if (func?.type === "function") {
     return `function ${func.name}(${func.inputs.map((input) => input.type).join(", ")})${func.outputs.length > 0 ? ` returns (${func.outputs.map((output) => output.type).join(", ")})` : ""}`;
-  } else {
-    throw new Error(`invalid function`);
   }
+  throw new Error("invalid function");
 }