Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Held-Suarez formulation not consistent with original paper #131

Open
PeterHjortLauritzen opened this issue Oct 9, 2024 · 0 comments
Open

Comments

@PeterHjortLauritzen
Copy link
Collaborator

    if (pref_mid_norm(k) > sigmab) then

in held_suarez_1994.F90 should be

    if (pmid(i,k)/ps(i) > sigmab) then

PS (actual surface pressure) is currently not passed to subroutine.

This PR would need to be coordinated with ESCOMP PR.

@cjablono working on PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant