Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Python system/unit tests to enable running anywhere #2984

Open
samsrabin opened this issue Mar 5, 2025 · 0 comments
Open

Improve Python system/unit tests to enable running anywhere #2984

samsrabin opened this issue Mar 5, 2025 · 0 comments
Labels
bfb bit-for-bit devops E.g., adding GitHub Workflows test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests

Comments

@samsrabin
Copy link
Collaborator

samsrabin commented Mar 5, 2025

There are some things preventing us from running the Python system and unit tests anywhere other than the NCAR clusters (or at least machines not specified in CIME's config_machines.xml). Aside from being a continuity risk, this means that we can't run them as GitHub workflows. This issue will serve as a parent for some thoughts I've had but haven't necessarily yet investigated.

Unit tests failing on my Mac:

These system tests fail without nco loaded, which complicates testing, especially on systems without it installed (#2988):

  • TestSysMeshMaskModifier.test_allInfo
  • TestSysMeshMaskModifier.test_modifyMesh

The following system tests fail on my Mac (with nco loaded), but I don't have time at the moment to investigate them. A quick look suggests they're probably all due to my machine's name not being in CIME's config_machines.xml file. If that's the case, I think two changes should be made: (1) add a entry in that file for GitHub runners and (2) catch those errors in our tests and throw a warning instead if no machine is found.

  • TestSysMeshMaskModifier.test_allInfo
  • TestSysMeshMaskModifier.test_modifyMesh
  • TestSysRunTower.test_ad_site
  • TestSysRunTower.test_one_site
  • TestSysRunTower.test_overwrite
  • TestSysRunTower.test_plumber_site
  • TestSysRunTower.test_setup_only
  • TestSysRunTower.test_xmlchange
@samsrabin samsrabin added bfb bit-for-bit next this should get some attention in the next week or two. Normally each Thursday SE meeting. test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests labels Mar 5, 2025
@samsrabin samsrabin added this to the Eventually milestone Mar 5, 2025
@samsrabin samsrabin added the devops E.g., adding GitHub Workflows label Mar 6, 2025
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit devops E.g., adding GitHub Workflows test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests
Projects
Development

No branches or pull requests

2 participants