Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify subset_data for CRUJRA with a more user-interactive solution #2960

Open
Tracked by #1895
ekluzek opened this issue Feb 11, 2025 · 11 comments
Open
Tracked by #1895

modify subset_data for CRUJRA with a more user-interactive solution #2960

ekluzek opened this issue Feb 11, 2025 · 11 comments
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science usability Improve or clarify user-facing options

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Feb 11, 2025

subset_data is hardwired to work with datm_gswp3.
The default datm dataset is changing for clm6 to CRUJRA2024.

I added this comment to subset_data.py in #2956:

    # TODO issue #1895: allow datm_crujra, which also affects
    #      tools/site_and_regional/default_data_1850.cfg
    #      tools/site_and_regional/default_data_2000.cfg
    #      python/ctsm/test/testinputs/default_data.cfg

and posted this comment.

#2956 continues to hardwire but for CRUJRA. In the future we want to make this a user-interactive option.

@wwieder
Copy link
Contributor

wwieder commented Feb 11, 2025

I'll note that I have an equally hard and brittle application of subset data that works for CRUJRA (currently unavailable on Derecho).

  • In the short term, we can bring this option in (having something that's functional with CRUJRA seems critical).
  • Alternatively, maybe it's not too difficult to make less brittle python code that can handle both options? (not sure how much we can support multiple datm products in our subsetting tools)?

@wwieder wwieder added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science usability Improve or clarify user-facing options labels Feb 11, 2025
@wwieder wwieder added this to the ctsm6.0.0 (code freeze) milestone Feb 11, 2025
@slevis-lmwg

This comment has been minimized.

@samsrabin
Copy link
Collaborator

Just met with Katie Rocci, who mentioned this being an issue in her work.

@slevis-lmwg
Copy link
Contributor

I contacted Katie to ask for more info, especially if she is stuck in some way.

@samsrabin
Copy link
Collaborator

Oh sorry, no, she worked around it. But it was a pain and she couldn't remember how exactly.

@wwieder
Copy link
Contributor

wwieder commented Mar 11, 2025

Sorry, would my hack for doing this with CRUJRA still be helpful here?

@samsrabin
Copy link
Collaborator

Depends on how quickly we can get this feature in. If not soon, then we should document your hack.

@wwieder
Copy link
Contributor

wwieder commented Mar 11, 2025

Looks like I have it in this WIP PR that's including two separate issues: the CRUJRA workflow to subset data with MIMICS changes. Happy to break these out into two different PRs, but I may need some hand holding to make this more effective with git.

@slevis-lmwg
Copy link
Contributor

@wwieder pretty much the same as your hack is coming in with #2956, so no need to do anything additional at this time. This issue is here to remind us to resolve this with a user-interactive solution rather than a hardwiring.

@slevis-lmwg slevis-lmwg changed the title modify subset_data for CRUJRA (currently hardcoded for GSWP3 and rather brittle). modify subset_data for CRUJRA (currently hardcoded and brittle). Mar 11, 2025
@wwieder
Copy link
Contributor

wwieder commented Mar 11, 2025

OK, Thanks @slevis-lmwg. If we have something that works with #2956, maybe we don't have this be a requirement for point and regional cases in CLM6. It seems like the configurations we want to support should really just include the default datm (and resolutions) we're using in I cases? Should we consider changing the milestone associated with this more interactive option that would be nice to have down the road?

@wwieder wwieder changed the title modify subset_data for CRUJRA (currently hardcoded and brittle). modify subset_data for CRUJRA with a more user-interactive solution Mar 11, 2025
@slevis-lmwg
Copy link
Contributor

[...] Should we consider changing the milestone associated with this more interactive option that would be nice to have down the road?

Sounds reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science usability Improve or clarify user-facing options
Projects
None yet
Development

No branches or pull requests

4 participants