Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FATES_ERROR_EL from the FatesColdST3 testmod #2850

Open
glemieux opened this issue Oct 28, 2024 · 3 comments · Fixed by #2782
Open

Remove FATES_ERROR_EL from the FatesColdST3 testmod #2850

glemieux opened this issue Oct 28, 2024 · 3 comments · Fixed by #2782

Comments

@glemieux
Copy link
Collaborator

Per NGEET/fates#1155 update, FATES_ERROR_EL does not have relevance to this test. FATES has been updated to remove this from the history output during this run mode and as such, will fail during RUN if this variable is included in the user_nl_clm history output.

@glemieux glemieux linked a pull request Oct 29, 2024 that will close this issue
@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 31, 2024
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Nov 7, 2024
@glemieux
Copy link
Collaborator Author

glemieux commented Nov 7, 2024

This is address for the FatesColdST3 test via ebf5f26.

@glemieux
Copy link
Collaborator Author

glemieux commented Nov 7, 2024

This is address for the FatesColdST3 test via ebf5f26.

Actually this doesn't address the issue given #2867 (comment).

The short term fix here is to clear the tapes and re-add the Fates testmod base variables to the FatesColdST3 user_nl_clm file, leaving the FATES_ERROR_EL out.

@glemieux
Copy link
Collaborator Author

Reopening this as my attempted fix in #2782 didn't really work.

@glemieux glemieux reopened this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants