Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

air_pressure_at_sea_level or air_pressure_at_mean_sea_level or both? #82

Open
ss421 opened this issue Nov 5, 2024 · 3 comments
Open
Assignees
Labels
question Further information is requested

Comments

@ss421
Copy link
Collaborator

ss421 commented Nov 5, 2024

As part of a recent code sprint, we adopted the CCPP name air_pressure_at_sea_level. This replaced the variable name surface_pressure_at_mean_sea_level. It was pointed out after the sprint that the new name omits mean and others have questioned why mean was removed. Based on post sprint discussion we have had in the UKMO, we feel the omission of mean is potentially ambiguous.

In further discussion with others in JEDI, it was also pointed out that according to the CF convention, _sea_level is short for _mean_sea_level, so they're the same and that _sea_surface is the instantaneous sea surface. Its not clear to me why CF have two names for the same thing other than one had been established and changing it was difficult (if someone knows the actual reason then please let me know).

While digging into the CCPP I see that this variable was added in 2021 via: #10 so it is an established CCPP name. The suffex at_sea_level is a defined:

although it does appear that it is only used by air_pressure.

Looking at the CCPP PR where this variable was added, there does not appear to be any discussion about the use of mean as we have highlighted here.

What do others think about this?

Tagging individuals involved in the original PR for further details and feedback: @cacraigucar @nusbaume @gold2718 @peverwhee

and those involved in the code sprint for referabce: @svahl991 @mikecooke77 @fmahebert @ncrossette @rtodling @sking112 @danholdaway @travissluka @BenjaminTJohnson @stemiglio

Thanks, Steve

@ss421 ss421 self-assigned this Nov 5, 2024
@ss421 ss421 added the question Further information is requested label Nov 5, 2024
@dudhia
Copy link
Collaborator

dudhia commented Nov 5, 2024 via email

@nusbaume
Copy link
Collaborator

nusbaume commented Nov 5, 2024

In general I support the more verbose names for quantities, so in this case it would be _mean_sea_level, but at the same time I do think it is generally understood that _sea_level implies the mean sea level, as I am actually not sure how one would determine "sea level" on land without using the mean value.

In other words I think either option works for us here at NCAR-CGD.

Alternatively, we could also just specify in the rules that sea_level means the average value, and then just leave the actual standard names as-is, at least until we find a use case where that no longer works?

@dudhia
Copy link
Collaborator

dudhia commented Nov 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants