Need configuration system to manage new atmospheric_physics directory structure #305
Assignees
Labels
Comments
nusbaume
added
enhancement
nusbaume
added a commit
that referenced
this issue
Oct 15, 2024
Originator(s): nusbaume Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): This PR bring in a new atmospheric_physics version with a re-organized directory structure. The way this impacts CAM-SIMA is that now when a physics suite is listed it will first look in the case's SourceMods first, `ncar_ccpp/suites` second, and `ncar_ccpp/test/test_suites` third, after which it will error if it hasn't found the Suite Definition File (SDF). The CAM-SIMA build system also now looks in `ncar_ccpp/schemes` for any CCPP physics source code and metadata files. Fixes #305 The associated atmospehric_physics PR can be found here: ESCOMP/atmospheric_physics#126 Describe any changes made to build system: The CAM-SIMA configuration routines will now look under `suites` or `test_suites` for SDFs, with the `suites` entries taking precedence (unless the case has SourceMods, in which those always take precedence). All of the relevant source code and metadata files for atmospheric physics must also now be present under the `schemes` directory in the atmospheric_physics repo. Describe any changes made to the namelist: N/A List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A List all files eliminated and why: Remove unused "test/include" directory: D test/include/Makefile D test/include/cam_abortutils.F90 D test/include/cam_logfile.F90 D test/include/ccpp_kinds.F90 D test/include/shr_infnan_mod.F90 D test/include/shr_kind_mod.F90 D test/include/spmd_utils.F90 List all files added and what they do: N/A List all existing files that have been modified, and describe the changes: (Helpful git command: git diff --name-status development...<your_branch_name>) Update atmospheric_physics external: M .gitmodules M src/physics/ncar_ccpp Update CCPP SDF, source, and metadata file search locations and precedence: M cime_config/cam_autogen.py Add FTJ16 compset and cleanup simple physics configuration options: M cime_config/config_component.xml If there are new failures (compare to the existing-test-failures.txt file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? derecho/intel/aux_sima: ALL PASS derecho/gnu/aux_sima: ALL PASS CAM-SIMA date used for the baseline comparison tests if different than latest:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Type
Infrastructure Update
Issue Description
The atmospheric_physics repo will soon have a reorganization where the Suite Definition Files (SDFs) will be located underneath a
suitesdirectory or atest/test_suitesdirectory (see ESCOMP/atmospheric_physics#124).Thus CAM-SIMA will need to look in those directories to find the user-specified physics suite, with the
suitesdirectory taking precedence over thetest/test_suitesdirectory.Will this change answers?
No
Will you be implementing this yourself?
Yes
The text was updated successfully, but these errors were encountered: