Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating and closing tabs too quickly can trigger the "What's wrong" error (whatsWrongMessage) where STG seemingly crashes #1267

Open
nekohayo opened this issue Mar 11, 2025 · 2 comments

Comments

@nekohayo
Copy link

nekohayo commented Mar 11, 2025

Describe the bug

I've been encountering this bug for years, when I open and close tabs too quickly, but I hadn't reported it until now.

To Reproduce
Steps to reproduce the behavior:

  1. Press Ctrl+T to open a new tab
  2. Immediately press Ctrl+W to close the tab.
    If the error does not occur, repeat steps 1 and 2 a couple of times quickly, as it might be dependent on the timing.

Result: STG's icon will change to a warning triangle symbol (⚠️) as if it had crashed, and you will get an error notification message that says, "Whats wrong...\nPlease contact with developer" ; it seems to be emitted from this part of the code:

        case 'show-error-notification':
            const isMessageSended = sendMessage('show-error-notification');

            Utils.notify(
                ['whatsWrongMessage'],
                undefined,
                'whatsWrongMessage',
                '/icons/exclamation-triangle-yellow.svg',
                () => !isMessageSended && Urls.openDebugPage()
            ).catch(() => { });

            result.ok = true;
            return result;

Expected behavior

Ideally, STG shouldn't be crashable this way :)

Desktop:

  • OS and version: Fedora 41 (Linux)
  • Firefox version: 136
  • Simple Tab Groups version: 5.3
@nekohayo
Copy link
Author

Alternatively, I think I've also seen this happen when I was closing tabs while Firefox was still busy re-loading the tabs on startup, if STG hadn't fully loaded... but this is just based on my memories, I am not 100% sure if that's the other way to reproduce it reliably.

@cweiske
Copy link

cweiske commented Mar 12, 2025

I nearly always get this error when switching to another tab group. This began when I upgraded to Firefox 136.0 yesterday.

This is with Simple Tab Groups 5.1.


Manually upgrading to 5.3.1 fixes the problem for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants