Skip to content

Commit b821ce2

Browse files
authored
Reducing the Use of oneof in Protos (valhalla#3527)
* remove enum oneofs from options.proto and info.proto * remove oneof from directions proto completely, too easy, thank you @dgearhart * no need for oneof in sign.proto * remove oneof from trip.proto, also move attributes controller to baldr and use it during serialization * remove more oneof's this time from common.proto * fix trace logs * costing can have a default of none more correlation stuff is non optional * move more outputs into the correlated structure * add a unit test for typo in heading tolerance, reimplement a similar check for route_leg_shape_index
1 parent 75ead87 commit b821ce2

File tree

98 files changed

+809
-1457
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+809
-1457
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
* CHANGED: Rename tripcommon to common [#3516](https://github.com/valhalla/valhalla/pull/3516)
6464
* ADDED: indoor routing - data model, data processing. [#3509](https://github.com/valhalla/valhalla/pull/3509)
6565
* ADDED: On-demand elevation tile fetching [#3391](https://github.com/valhalla/valhalla/pull/3391)
66+
* CHANGED: Remove many oneof uses from the protobuf api where the semantics of optional vs required isnt necessary [#3527](https://github.com/valhalla/valhalla/pull/3527)
6667

6768
## Release Date: 2021-10-07 Valhalla 3.1.4
6869
* **Removed**

0 commit comments

Comments
 (0)