Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/allow override ref #428

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Feat/allow override ref #428

merged 3 commits into from
Feb 27, 2025

Conversation

dhutchison
Copy link
Collaborator

Fixes #414, fixes #415, fixes #410

Adds support for overriding the value for !Ref through resource metadata, and updates test cases and documentation to include how this can be done without modifying the actual template itself

@dhutchison dhutchison added enhancement New feature or request minor A new feature has been added. labels Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (042fa5e) to head (16c6ae4).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #428      +/-   ##
===========================================
+ Coverage    94.58%   94.60%   +0.01%     
===========================================
  Files           12       12              
  Lines          850      853       +3     
  Branches       160      160              
===========================================
+ Hits           804      807       +3     
  Misses          25       25              
  Partials        21       21              
Flag Coverage Δ
unit 94.60% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhutchison dhutchison changed the base branch from master to develop February 19, 2025 01:06
@dhutchison dhutchison requested a review from shadycuz February 26, 2025 22:55
Copy link
Member

@shadycuz shadycuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhutchison Another great addition, thank you! =)

@shadycuz shadycuz merged commit 7554e65 into develop Feb 27, 2025
11 checks passed
@shadycuz shadycuz deleted the feat/allow-override-ref branch February 27, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor A new feature has been added.
Projects
None yet
2 participants