Skip to content

Commit 94d5285

Browse files
dhutchisonshadycuz
authored andcommitted
fix(unit-template): fix typo and docs #384
1 parent 648bc29 commit 94d5285

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,6 @@ A real functional testing example using Pytest can be seen [here](./tests/test_c
325325
### Unit
326326
- Add full functionality to pseudo variables.
327327
* Variables like `Partition`, `URLSuffix` should change if the region changes.
328-
* Variables like `StackName` and `StackId` should have a better default than ""
329328
- Handle References to resources that shouldn't exist.
330329
* It's currently possible that a `!Ref` to a Resource stays in the final template even if that resource is later removed because of a conditional.
331330

src/cloud_radar/cf/unit/_template.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class Template:
2727
NoValue: str = "" # Not yet implemented
2828
Partition: str = "aws" # Other regions not implemented
2929
Region: str = "us-east-1"
30-
StackId: str = "" # If left black this will be generated
30+
StackId: str = "" # If left blank this will be generated
3131
StackName: str = "my-cloud-radar-stack"
3232
URLSuffix: str = "amazonaws.com" # Other regions not implemented
3333

0 commit comments

Comments
 (0)