Skip to content

issues Search Results · repo:DockYard/ember-router-scroll language:JavaScript

Filter by

82 results
 (48 ms)

82 results

inDockYard/ember-router-scroll (press backspace or delete to remove)

DockYard/ember-router-scroll
Allow nested controllers to override preserveScrollPosition

Use case: Only want to apply ember router scroll s default behavior (scroll up on route change) on certain pages of the site. Possible solution: set preserveScrollPosition to true on application controller, ...
  • Gaurav0
  • Opened 
    on Mar 6, 2023
  • #319

DockYard/ember-router-scroll
Prevents apps from stubbing router service in unit tests

This addon eagerly instantiates its service in an instance-initializer: https://github.com/DockYard/ember-router-scroll/blob/2f17728fd82d7d486888df9a09fdc4aae233f294/addon/instance-initializers/ember-router-scroll.js#L3 ...
  • ef4
  • 1
  • Opened 
    on Jan 19, 2022
  • #304

DockYard/ember-router-scroll
Allow configuration of MAX_ATTEMPTS for tryScrollRecursively

Currently, MAX_ATTEMPTS is set locally on the add-on service with a value of 100. Which for most cases is fine, but I ve run into a few instances where I need to try a few more times before the page is ...
  • jleja
  • Opened 
    on Sep 1, 2021
  • #286

DockYard/ember-router-scroll
README Correction - export DEFAULT class...

The README s 4.x section has a type; should read export default class ... ... the default is missing. This can lead to strange message about not being able to find router:main at runtime. This is the ...
  • nadnoslen
  • 2
  • Opened 
    on Feb 5, 2021
  • #278

DockYard/ember-router-scroll
Upgrade to version 4.x leads to test errors

I m trying to upgrade ember-router-scroll from v3.3.3 to v4.x in our project. I did the necessary adjustments in the router.js according to the README. The project starts and works as expected. Some tests ...
  • freyjameetsmel
  • 7
  • Opened 
    on Jan 22, 2021
  • #273

DockYard/ember-router-scroll
Deprecation warning still present in 4.0

Hi there! I just updated ember-router-scroll to ^4.0.0 in my app (Ember 3.16) and I am seeing the following warning in the console: DEPRECATION: The use of Ember.Router in setupRouter is deprecated. ...
  • gzurbach
  • 5
  • Opened 
    on Jan 6, 2021
  • #271

DockYard/ember-router-scroll
Don't scroll on initial load

Hi, thanks for the great addon! With FastBoot, the user is able to scroll down the static HTML version of the app. When the app rehydrates, ember-router-scroll resets scrolling, producing jerky behavior. ...
  • lolmaus
  • 3
  • Opened 
    on Nov 10, 2020
  • #263

DockYard/ember-router-scroll
Restore scroll position after transition, via history.back(), resolves

Below is a BDD description of the issue. - Given routes A and B - And route A has a model method that returns a promise from store.findAll method - And the promise resolves with an empty records ...
  • GCheung55
  • 2
  • Opened 
    on Sep 2, 2020
  • #260

DockYard/ember-router-scroll
Use `RouterService` instead of extending Ember `Router`

Similar to https://github.com/ember-app-scheduler/ember-app-scheduler/issues/772. Looking at what actually happens in EmberRouterScroll it only seems like routeWillChange and routeDidChange are bound. ...
  • buschtoens
  • Opened 
    on Jul 29, 2020
  • #255

DockYard/ember-router-scroll
Don't scroll the page during the tests

It looks like when I run the tests, this plugin always resets the document scroll where the test report is shown. This should not happen. At least, it should reset the scroll inside the #ember-testing-container ...
  • gedaiu
  • Opened 
    on Jul 2, 2020
  • #253
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub