-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz app #101
Quiz app #101
Conversation
Please review @Abirpal202049 @thepranaygupta @bhavesh-chaudhari @saikatmu31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the vscode file
Removed! @nandini7637 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a bug in progress bar(timeline). It is progressing even after the counter has stopped. Can you confirm this ? If this is happening with you too then please try to fix it.
I have checked, It's working fine! |
Here you can see, I have checked just now: video.mp4 |
Oh! I haven't checked for other browsers, will fix it soon! |
Fixed the timeline, Please review! @bhavesh-chaudhari |
The timeline is still showing unexpected behaviour as before on firefox. Can you show a preview that it is working fine ? |
It is showing same time results. |
The Time Spent in above images is actually not the time spent but seems to be number of loops you are using(which is independent of browsers). If you read my older message then you can see both no. of loops and time taken. Also the issue is with setInterval() method as it was explained in the previous message. Its behaviour changes with user browsers, devices, etc. so the animation will look different to different users. For more details please go through the links i had shared earlier it does contain the correct solution too ! |
@bhavesh-chaudhari Please see here, how it's showing for me on firefox: Timing results are almost same on Google and Firefox. |
Fixes: #94