Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz app #101

Closed
wants to merge 3 commits into from
Closed

Quiz app #101

wants to merge 3 commits into from

Conversation

Sumandeep-Kaur
Copy link
Contributor

Fixes: #94

@nandini7637 nandini7637 added SWoC This is exclusive for SWoC participants. Swoc Lv3 labels Jan 19, 2022
@Sumandeep-Kaur
Copy link
Contributor Author

Copy link
Member

@nandini7637 nandini7637 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the vscode file

@Sumandeep-Kaur
Copy link
Contributor Author

Please remove the vscode file

Removed! @nandini7637

Copy link
Collaborator

@bhavesh-chaudhari bhavesh-chaudhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a bug in progress bar(timeline). It is progressing even after the counter has stopped. Can you confirm this ? If this is happening with you too then please try to fix it.

@Sumandeep-Kaur
Copy link
Contributor Author

There seems to be a bug in progress bar(timeline). It is progressing even after the counter has stopped. Can you confirm this ? If this is happening with you too then please try to fix it.

I have checked, It's working fine!

@Sumandeep-Kaur
Copy link
Contributor Author

Here you can see, I have checked just now:

video.mp4

@bhavesh-chaudhari
Copy link
Collaborator

There seems to be a bug in progress bar(timeline). It is progressing even after the counter has stopped. Can you confirm this ? If this is happening with you too then please try to fix it.

I have checked, It's working fine!

I just rechecked and it is working as expected in chrome but this is how it works in firefox -

quiz_app_firefox_bug.mp4

On firefox it is taking around 17 seconds for the timeline to finish as you can see here(expected time to finish progressing is 10 seconds) -

image

Whereas it takes around 11 seconds on chrome -

image

This is because browsers don't give much accuracy in setInterval or setTimeout especially when the delay is very small(like 20ms in this example).

Checkout this for more insights about the bug and how to go about fixing it -

@Sumandeep-Kaur
Copy link
Contributor Author

Oh! I haven't checked for other browsers, will fix it soon!

@Sumandeep-Kaur
Copy link
Contributor Author

Fixed the timeline, Please review! @bhavesh-chaudhari

@bhavesh-chaudhari
Copy link
Collaborator

Fixed the timeline, Please review! @bhavesh-chaudhari

The timeline is still showing unexpected behaviour as before on firefox. Can you show a preview that it is working fine ?

@Sumandeep-Kaur
Copy link
Contributor Author

Fixed the timeline, Please review! @bhavesh-chaudhari

The timeline is still showing unexpected behaviour as before on firefox. Can you show a preview that it is working fine ?

It is showing same time results.

Here's it is on Chrome--
Screenshot (26)


And this is on Firefox--
Screenshot (25)

@bhavesh-chaudhari
Copy link
Collaborator

Fixed the timeline, Please review! @bhavesh-chaudhari

The timeline is still showing unexpected behaviour as before on firefox. Can you show a preview that it is working fine ?

It is showing same time results.

Here's it is on Chrome-- Screenshot (26) And this is on Firefox-- Screenshot (25)

The Time Spent in above images is actually not the time spent but seems to be number of loops you are using(which is independent of browsers). If you read my older message then you can see both no. of loops and time taken. Also the issue is with setInterval() method as it was explained in the previous message. Its behaviour changes with user browsers, devices, etc. so the animation will look different to different users. For more details please go through the links i had shared earlier it does contain the correct solution too !

@Sumandeep-Kaur
Copy link
Contributor Author

Fixed the timeline, Please review! @bhavesh-chaudhari

The timeline is still showing unexpected behaviour as before on firefox. Can you show a preview that it is working fine ?

@bhavesh-chaudhari Please see here, how it's showing for me on firefox:
https://user-images.githubusercontent.com/77191007/155551835-d6fd7f67-621b-4e36-98cd-609c8ba1f2e5.mp4

Timing results are almost same on Google and Firefox.

This is on Google:
google

And this is on Firefox:
firefox

@Sumandeep-Kaur Sumandeep-Kaur closed this by deleting the head repository Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Swoc Lv3 SWoC This is exclusive for SWoC participants.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiz Application
5 participants