make chatbot.py lower case and add project configuration files #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DaanRosendal
commented
Feb 19, 2025
DaanRosendal
commented
- Renamed Chatbot.py to chatbot.py
- Added .pylintrc for linting configuration
- Updated Dockerfile to use lowercase chatbot.py
- Minor improvements to login, profile, and utils pages
- Refined GitHub workflow configuration
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
pages/utils/init.py:9
- Caching a database connection using @st.cache_resource may lead to stale connections or shared state issues across sessions. Consider re-evaluating whether caching is appropriate for a stateful resource like a DB connection or instantiate a new connection as needed.
@st.cache_resource
- Created chatbot.py with OpenAIChatbot class using Streamlit and Azure APIs - Added .pylintrc for linting configuration - Updated Dockerfile to use lowercase chatbot.py - Minor improvements to login, profile, and utils pages - Refined GitHub workflow configuration
DaanRosendal
force-pushed
the
minor-changes
branch
from
76278e2 to
cf165a3
Compare
Timmy1012
requested changes
Feb 19, 2025
chatbot.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| """ | |||
| Chatbot application for University of Amsterdam students using OpenAI and Azure Search. | |||
| """ | |||
| """ # noqa: E501 | |||
There was a problem hiding this comment.
Why not add E501 to the global pylint ignore?
There was a problem hiding this comment.
It's flake8, but good point anyway. Done
- Added .flake8 configuration file to ignore line length warnings - Removed `# noqa: E501` comments from chatbot.py, login.py, profile.py, and utils/__init__.py - Simplified docstrings and comments by removing line length annotations
- Modified .pylintrc to disable specific linting warnings - Simplified static analysis workflow by removing explicit pylint configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.