Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing item sources after Heresy update #10935

Open
bhollis opened this issue Feb 5, 2025 · 2 comments
Open

Fix missing item sources after Heresy update #10935

bhollis opened this issue Feb 5, 2025 · 2 comments

Comments

@bhollis
Copy link
Contributor

bhollis commented Feb 5, 2025

Something about how we calculate item sources (e.g. "campaign", "ironbanner") has changed in the Heresy manifest update, causing us to lose a lot of them:

d2feaae#diff-8661a7052566e03b61227d174baf3e362fb0fb21a0b54f64a062b0c7def0c928

We should figure out how to get them back. I'm guessing the fix needs to be in d2ai.

@Skinwalker1969

This comment has been minimized.

@bhollis bhollis changed the title Fix missing sources after Heresy update Fix missing item sources after Heresy update Feb 5, 2025
@bhollis
Copy link
Contributor Author

bhollis commented Feb 16, 2025

The new manifest fixed some of them: https://github.com/DestinyItemManager/DIM/pull/10942/files#diff-8661a7052566e03b61227d174baf3e362fb0fb21a0b54f64a062b0c7def0c928

But the ironbanner ones are still missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants