-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sheets can lose their scroll bar (Filters Help) #10346
Comments
Related to #9240, caused by sheets recalculating their maximum height incorrectly |
Is the issue that the sheet is calculating the max height but loading contents is async? If that is the case we need to provide the contents a callback it can call when its contents have loaded correctly. Edit: The async nature is due to react suspense, which react handles correctly if we put the sheet behind the suspense boundary too. |
@robojumper can you test and close for me? It should be live on beta now. |
I'm still seeing this with given repro steps in Version 8.19.0.3324 (beta) |
Hmmm ok, it must be something else. It fixed the other issue Ben linked. I will have a look. |
@robojumper I cannot reproduce this on chrome or firefox (125 video attached). Could this be a windows thing? Screen.Recording.2024-05-09.at.6.44.47.PM.mov |
This affects the desktop layout for me. You might be able to reproduce it with the dev tools mobile emulation turned off? |
I tried both, which are both fine for me. I will get a vid of firefox there too |
I'll try reproduce this on my gaming PC when I get a chance and remember to. |
Just tried this again on Firefox 126 and 125.03 on windows and I don't see the issue. @robojumper do you have any non default settings enabled in firefox? |
Ok, I will try with that next. |
I wasn't able to repro on Chrome or Firefox for macOS. |
Yeah I have tried a few combo's and can't repro. I need to do the edge one but I think this is due to something non-default in robo's settings. |
as soon as i type the |
And to be clear @delphiactual it doesn't come back once deleting everything? Also, what version of windows? I am on 11 and note that robo is on 10. So if you are on 10 maybe its a 10 thing |
i am on win 11, and it does not come back |
Managed to reproduce on chrome (I swear I checked that initially). PTAL at the fix if you get a chance. |
This also seems related to #9886 potentially? There seems to be some weird behaviour with this useResizerObserver hook |
DIM Version
Version 8.16.0.3284 (beta), built on 4/16/2024, 10:58:13 PM
Browser Details
Edge 123, Firefox 125
OS Details
Windows 10
Describe the bug
123
in the sheet search bar, which doesn't match any filtersLogs
The text was updated successfully, but these errors were encountered: