Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osx + gcc + WITH_QPBO #63

Open
DerThorsten opened this issue May 23, 2017 · 2 comments
Open

osx + gcc + WITH_QPBO #63

DerThorsten opened this issue May 23, 2017 · 2 comments

Comments

@DerThorsten
Copy link
Owner

DerThorsten commented May 23, 2017

Seems like there are some linking/ multiple definitions of problems on os + gcc + WITH_QPBO
when building the qpbo lib

https://travis-ci.org/DerThorsten/nifty/jobs/235373715

@DerThorsten DerThorsten changed the title os + clang + WITH_QPBO os + gcc + WITH_QPBO May 23, 2017
@DerThorsten DerThorsten changed the title os + gcc + WITH_QPBO osx + gcc + WITH_QPBO May 28, 2017
@bluescarni
Copy link
Contributor

I noticed that in the QPBO code there are methods of class templates defined in .cpp files, some with inline some not. My suspicion is that the linking problems are related to this.

Is there a specific reason why the code should be split up in .cpp/.hpp for these class templates?

@DerThorsten
Copy link
Owner Author

I guess the easiest thing is to turn this into a header only lib.
I can easily do this in my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants