-
Notifications
You must be signed in to change notification settings - Fork 26
Unused let
in the LINQ expression changes result of Query
#402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
let
in the LINQ expression makes query incorrectlet
in the LINQ expression changes result of Query
This was referenced Oct 31, 2024
SergeiPavlov
added a commit
to servicetitan/dataobjects-net
that referenced
this issue
Nov 6, 2024
SergeiPavlov
added a commit
to servicetitan/dataobjects-net
that referenced
this issue
Nov 6, 2024
SergeiPavlov
added a commit
to servicetitan/dataobjects-net
that referenced
this issue
Nov 6, 2024
…` bug (#300) * Fix DataObjects-NET#402: * Fix typo * Revert "Fix typo" This reverts commit 57389e0. * Remove RedundantColumnOptimizer * Revert "Fix DataObjects-NET#402:" This reverts commit 6ac3945.
Two problems were discovered during investigation of this case
First issue appeared after changes released in 6.0.13 and traversed to newer branches via merge. @SergeiPavlov the PR that fixes both of issues, and because root of at least one of problems lied in 6.0 branch I had to resolve it there. Soon these changes will be merged into newer branches |
alex-kulakov
added a commit
that referenced
this issue
Dec 4, 2024
Resolves several query translation issues declared in #402 Addresses issue which appeared in 6.0.13, which roots to not fully visited of key expression in GroupBy Addressed issue of incorrect optimization of query with several In() calls within RedundantColumnOptimizer, which could cause wrong source of parameters for IN statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The expression:
The test to reproduce it:
https://github.com/DataObjects-NET/dataobjects-net/pull/401/files
Looks like
let
works aswhere
filter.It is a simlified example.
In the real app we discovered the same effect with used variable in
let
.We thought the behavior changed after merging https://github.com/dataObjects-net/dataobjects-net commits for last 7 months.
But after some investigation I see the bug is here for longer time, may be from the beginning.
The text was updated successfully, but these errors were encountered: