Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into Agent changes for running ADP on Windows. #519

Open
tobz opened this issue Feb 20, 2025 · 3 comments
Open

Look into Agent changes for running ADP on Windows. #519

tobz opened this issue Feb 20, 2025 · 3 comments
Labels
area/config Configuration. type/enhancement An enhancement in functionality or support.

Comments

@tobz
Copy link
Member

tobz commented Feb 20, 2025

Currently, we do not build ADP on Windows. As part of doing so, we'll have to consider how to actually use ADP on Windows with the Agent, which means running ADP like any other subagent.

From some internal chats, it seems like this hinges on two main bits of work:

  • creating/install a Windows service for ADP
  • updating the Core Agent to actually trigger the service start/stop for the ADP service when ADP is enabled

We should investigate further to understand the scope of these items, and if there are any other chunks of work we'll need to do in order to support running ADP on Windows, as the potential of requiring Agent changes means the iteration time of fixing bugs with adding said support becomes much, much higher than just updating the s6 files we bundle in the Linux container image, etc.

@tobz tobz added area/config Configuration. type/enhancement An enhancement in functionality or support. labels Feb 20, 2025
@tobz
Copy link
Member Author

tobz commented Feb 20, 2025

Random note: on Windows, we pass a -foreground flag to subagents when running them in Kubernetes (here).. so we should investigate what that flag is actually doing and if that's a specific bit of functionality we need to add to ADP.

@tobz
Copy link
Member Author

tobz commented Feb 20, 2025

Agent subcommand logic that figures out which Windows services to start/stop based on specific configuration values: https://github.com/DataDog/datadog-agent/blob/main/cmd/agent/subcommands/run/dependent_services_windows.go#L32-L73

@tobz
Copy link
Member Author

tobz commented Feb 20, 2025

Example code for how we define and add the Windows services themselves during installation: https://github.com/DataDog/datadog-agent/blob/main/tools/windows/DatadogAgentInstaller/WixSetup/Datadog%20Agent/AgentInstaller.cs#L563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Configuration. type/enhancement An enhancement in functionality or support.
Projects
None yet
Development

No branches or pull requests

1 participant