From 427c6f335e84ee45d467fa8299f2c62e757577a5 Mon Sep 17 00:00:00 2001 From: Justin Johnson Date: Mon, 10 Feb 2025 15:11:40 -0800 Subject: [PATCH 1/2] Add missing decrement method to NoopDogStatsDClient The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. --- packages/dd-trace/src/noop/dogstatsd.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/dd-trace/src/noop/dogstatsd.js b/packages/dd-trace/src/noop/dogstatsd.js index 899ac11e228..24abcc7306c 100644 --- a/packages/dd-trace/src/noop/dogstatsd.js +++ b/packages/dd-trace/src/noop/dogstatsd.js @@ -1,6 +1,8 @@ module.exports = class NoopDogStatsDClient { increment () { } + decrement () { } + gauge () { } distribution () { } From 4c1d926b9dd651f3ac204da07906ee786ee6454d Mon Sep 17 00:00:00 2001 From: Justin Johnson Date: Mon, 10 Feb 2025 15:30:23 -0800 Subject: [PATCH 2/2] tests --- packages/dd-trace/test/proxy.spec.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/dd-trace/test/proxy.spec.js b/packages/dd-trace/test/proxy.spec.js index 562c70f4336..b09e2207a21 100644 --- a/packages/dd-trace/test/proxy.spec.js +++ b/packages/dd-trace/test/proxy.spec.js @@ -75,6 +75,7 @@ describe('TracerProxy', () => { noopDogStatsDClient = { increment: sinon.spy(), + decrement: sinon.spy(), gauge: sinon.spy(), distribution: sinon.spy(), histogram: sinon.spy(), @@ -676,6 +677,8 @@ describe('TracerProxy', () => { it('should not throw when calling noop methods', () => { proxy.dogstatsd.increment('inc') expect(noopDogStatsDClient.increment).to.have.been.calledWith('inc') + proxy.dogstatsd.increment('dec') + expect(noopDogStatsDClient.decrement).to.have.been.calledWith('dec') proxy.dogstatsd.distribution('dist') expect(noopDogStatsDClient.distribution).to.have.been.calledWith('dist') proxy.dogstatsd.histogram('hist')