-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature gate support to helm chart #262
Comments
This feature is also wanted here ;p |
Sounds reasonable to me to have a way to add env vars to the Helm chart -- I'm making a ticket in our backlog for it, but I'd also welcome a PR if anyone wants to take a swing at it. |
This change adds 3 new features: - The ability to enable feature flags with the .Values.features key - The ability to add extra environment variables to the container env - The ability to completely override env variables (not recommended) Closes CrunchyData#262
I just came across this issue when trying to enable AutoGrow volumes. I've added a PR which addresses the problem with a number of potential ways to solve. I'd like to ask that the chart version also be disconnected from the PGO version. That will ensure that folks that use gitops tools like flux are able to pick up the change because of the bumped chart version. |
Hey folks I wanted to highlight patches that are something that you can use to patch the helm charts after generation using kustomize while you wait for the associated PR fix. Here's an example patch I'm using for adding a feature flag:
You can find more information about patches here. If you're using flux gitops like me then here's a link to that too in the meantime. I also found this post very useful to understand how to modify maps and arrays. |
This change adds 3 new features: - The ability to enable feature flags with the .Values.features key - The ability to add extra environment variables to the container env - The ability to completely override env variables (not recommended) Closes CrunchyData#262
It would be really nice if the Helm chart supported feature gates. Currently, there is no way to inject a custom env value into the chart manifest so feature gates are essentially non-operable.
The text was updated successfully, but these errors were encountered: