Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnoticed colour change with threshold 0 #25

Open
steffanwilliams opened this issue Nov 20, 2018 · 2 comments
Open

Unnoticed colour change with threshold 0 #25

steffanwilliams opened this issue Nov 20, 2018 · 2 comments

Comments

@steffanwilliams
Copy link

steffanwilliams commented Nov 20, 2018

While comparing latest screenshots to baseline, I expected that the following colour difference would have triggered a test failure, however this still passes:

badge--destructive

badge--destructive-1

I have threshold: 0 specified in my config, but I just wanted to check if there still some tolerance being applied when comparing screenshots?

@steffanwilliams steffanwilliams changed the title Unnoticed colour change with tolerance 0 Unnoticed colour change with threshold 0 Nov 20, 2018
@SeanThompsonUptick
Copy link

Tried this today and it only works if the threshold optional parameter is not passed at all. Threshold set to anything causes the test to pass, even when I completely change padding and colour of the element.

@mj-watts
Copy link

mj-watts commented Aug 5, 2021

For me if threshold is 0 then tests will pick up differences but if anything over 0 (0.1, 0.01) tests will pass with even major text changes, so something is broken here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants