Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory matching ignores parent directories #20

Open
webnard opened this issue Apr 2, 2014 · 0 comments
Open

Directory matching ignores parent directories #20

webnard opened this issue Apr 2, 2014 · 0 comments

Comments

@webnard
Copy link

webnard commented Apr 2, 2014

If I have a tree like the following, I am unable to just ignore the private/data directory using --ignore-dir="private/data". I must use --ignore-dir="data", but if I do that my other data directories are removed.

   |-app
   |---cool
   |-----data
   |-data
   |-private
   |---data
   |---do-not-delete

The relevant code is on line 172 of lib/crxmake.rb: File.basename(path). Is there any reason not to just match against the full path? The same could be applied to files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant