Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix: logic on classroom reservation record managing #635

Open
q1zhen opened this issue Oct 17, 2024 · 4 comments
Open

minor fix: logic on classroom reservation record managing #635

q1zhen opened this issue Oct 17, 2024 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@q1zhen
Copy link
Member

q1zhen commented Oct 17, 2024

Currently one may only manage the classroom reservation records created by his / her own. What is logically reasonable should be that one could manage the records associated with all clubs he / she has access to.

This is not a very urgent issue as this feature is not likely to be used until next semester.
@q1zhen
Copy link
Member Author

q1zhen commented Oct 17, 2024

@at-wr

@q1zhen q1zhen added bug Something isn't working enhancement New feature or request labels Oct 21, 2024
@at-wr
Copy link
Contributor

at-wr commented Jan 19, 2025

Probably fixed in 94a90ac?
Further verification required.

@at-wr
Copy link
Contributor

at-wr commented Jan 19, 2025

Probably fixed in 94a90ac? Further verification required.

New to VSC, and I'm too dumb to click the Commit & Create Pull Request in the Version Control panel, so I accidentally pushed it directly to the next branch lol, hopefully it's not a big issue :(

@q1zhen
Copy link
Member Author

q1zhen commented Jan 19, 2025

LGTM. Make sure to do some tests on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@at-wr @q1zhen