Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTask] Remove uvPty callback before exiting #896

Open
webfiltered opened this issue Feb 13, 2025 · 0 comments
Open

[DevTask] Remove uvPty callback before exiting #896

webfiltered opened this issue Feb 13, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@webfiltered
Copy link
Contributor

webfiltered commented Feb 13, 2025

Current

node-pty callback calls AppWindow.send()

  1. Close window
  2. AppWindow object destroyed
  3. Race condition:
    • IPC data triggers callback
    • Main process exits

Unhandled exception when IPC data wins.

Proposed

Kill node-pty process and ensure callback removal in before-quit or other early event.

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the bug Something isn't working label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant