Skip to content
This repository was archived by the owner on Nov 13, 2021. It is now read-only.

Health check middleware #82

Open
MassimoC opened this issue Jan 23, 2019 · 5 comments
Open

Health check middleware #82

MassimoC opened this issue Jan 23, 2019 · 5 comments

Comments

@MassimoC
Copy link
Collaborator

consider to use the health check middleware (ASPNET core 2.2)
https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/health-checks?view=aspnetcore-2.2

@MassimoC MassimoC added enhancement New feature or request maturity-level:two labels Jan 23, 2019
@tomkerkhove
Copy link
Contributor

The idea of this is great but the implementation is not there yet imo.

For example it has no support for OpenAPI so it will not work with gateways

@MassimoC
Copy link
Collaborator Author

Actually in the first simple implementation I've explicitly excluded the Health check controller from the Open API generation ([ApiExplorerSettings(IgnoreApi = true)])
I thought was better to hide all those technical operations ... I don't have a clear opinion on this.

@tomkerkhove
Copy link
Contributor

My vision on this is that it should be include to improve discovery. Restricted access is up to the gateway or app

But it's up to you

@MassimoC
Copy link
Collaborator Author

Add this as guidance on the maturity level2

@tomkerkhove
Copy link
Contributor

I can pick this up if you want

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants