Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"fit" arg to combine_CAMEL_coefs() is unused? #40

Open
brews opened this issue Sep 16, 2022 · 1 comment
Open

"fit" arg to combine_CAMEL_coefs() is unused? #40

brews opened this issue Sep 16, 2022 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@brews
Copy link
Member

brews commented Sep 16, 2022

def combine_CAMEL_coefs(

dscim.preprocessing.midprocessing.combine_CAMEL_coefs() takes a fit arg as a bool, but this is unused and almost immediately overwritten to a dict, but then used in a bool-like way.

At the very least, this is misleading and in need of clean up and clarification.

@brews brews added bug Something isn't working help wanted Extra attention is needed labels Sep 16, 2022
@davidrzhdu
Copy link
Contributor

I think fit is used in the if statement. I would suggest renaming the dict instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants