Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that dodola.services.validate actually fails bad data #189

Open
brews opened this issue Mar 31, 2022 · 0 comments
Open

Test that dodola.services.validate actually fails bad data #189

brews opened this issue Mar 31, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@brews
Copy link
Member

brews commented Mar 31, 2022

We test dodola.services.validate in dodola.tests.test_services.test_validation() for the "happy path" (well-behaved data), but it would be great if we could test to ensure validation correctly catches each of the conditions that it's supposed to catch.

I think I've mentioned this in a few previous PRs, but I'm putting it here so we dont' forget.

@brews brews added enhancement New feature or request help wanted Extra attention is needed labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant