Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In nocrash.py, when the main SD code is crashing, nocrash.py should check for new commits, in addition to just reverting. #11980

Open
makyen opened this issue Jul 7, 2024 · 0 comments
Labels
status: confirmed Confirmed as something that needs working on. type: feature request Shinies.

Comments

@makyen
Copy link
Contributor

makyen commented Jul 7, 2024

There have been cases in the past where changes, particularly in Stack Exchange, result in SD continuously crashing. The current logic in nocrash.py is that we start reverting back through the commit history in order to find a commit which doesn't crash. That's a good strategy, if the problem is a broken change we've made to SD and SD just needs to get back to a commit that doesn't have the broken changes.

However, in some fault cases, such a prior commit might not exist (or might be hundreds or thousands of commits in the past). In such cases, the only effective solution is new code. So, when nocrash.py is in its revert loop, it should also check to see if there is new code. If there's new code that qualifies (i.e., has passed CI), then it should pull that code and try it. If that code still crashes, nocrash.py should return to the revert process where it left off. This should be repeated, if there's yet more new code.

@makyen makyen added type: feature request Shinies. status: confirmed Confirmed as something that needs working on. labels Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Confirmed as something that needs working on. type: feature request Shinies.
Development

No branches or pull requests

1 participant