Crash on import pkpass without pass data

[brainrom]

Version: 2.34.4 from F-Droid

Catima crashed when I tried to import loyalty card from pkpass file.

Crash happens because of this unhandled exception

Android/app/src/main/java/protect/card_locker/PkpassParser.kt

Line 320 in 3f9b772

throw FormatException(mContext.getString(R.string.errorReadingFile))

Pkpass file may not contain one of "boardingPass", "coupon", "eventTicket", "generic" fields. Manually adding empty "generic" field to the pkpass, solved the problem with certain pkpass and it successfully imported, because import of passdata just inserts text in card description/note field and nothing more.

Maybe change this confition to !hasPassData || !pkPassHasBarcodes and then add exception handler with meaningful message.

Android/app/src/main/java/protect/card_locker/PkpassParser.kt

Line 319 in 3f9b772

if (!hasPassData) {

Thank you.

[TheLastProject]

That exception is not supposed to be unhandled, oops! That's definitely the main bug here: it shouldn't crash, that message should be displayed to the user.

The pkpass documentation states that the type shows which style a pkpass file should be displayed with, which Catima doesn't do anything with yet. I can't really find documentation if one of those fields is required right now, so maybe we can just assume a "generic" style in the future if none of them is defined.

So, to fix:

1. Properly bubble up the exception so it shows to the user
2. Allow Catima to deal with none of the fields existing (your suggested fix sound good in principle, would have to double-check when coding)

[brainrom]

Thank you for quick response!
Will you fix it? I'm not an Android developer.