Fix pre-commit complaints

I was not able to make the noqa: U031 (should not use % formatting) to
work, so I went for f-string and doubled the existings brackets. It's
ugly but I don't know what else to do.

Author: Carreau

.pre-commit-config.yaml

@@ -51,7 +51,7 @@ repos:
         args:
           [
             "--ignore-words-list",
-            "ags,aray,asend,ba,classs,crate,falsy,feld,inflight,lits,nd,slowy,te,oint,conveniant",
+            "ags,aray,asend,ba,crate,falsy,feld,inflight,lits,nd,slowy,te,oint,conveniant,atmost",
           ]
         exclude: ^(benchmark/benchmarks/pystone_benchmarks/pystone\.py|src/js/package-lock\.json)$
 

packages/_tests/test_packages_common.py

@@ -97,7 +97,7 @@ def _get_file_count(expr):
 
     def _import_pkg():
         for import_name in import_names:
-            selenium_standalone.run_async("import %s" % import_name)
+            selenium_standalone.run_async(f"import {import_name}")
 
     benchmark(_import_pkg)
 

packages/matplotlib/test_matplotlib.py

@@ -152,7 +152,7 @@ def test_font_manager(selenium):
     # get fontlist from build
     fontlist_built = json.loads(json.dumps(fm.FontManager(), cls=fm._JSONEncoder))
 
-    # reodering list to compare
+    # reordering list to compare
     for list in ("afmlist", "ttflist"):
         for fontlist in (fontlist_vendor, fontlist_built):
             fontlist[list].sort(key=lambda x: x["fname"])

packages/opencv-python/extras/detect_ffmpeg.cmake

@@ -30,8 +30,8 @@ elseif(OPENCL_INCLUDE_DIR)
 else()
     set(__opencl_dirs "${OpenCV_SOURCE_DIR}/3rdparty/include/opencl/1.2")
 endif()
-# extra dependencies for buildin code (OpenCL dir is required for extensions like cl_d3d11.h)
-# buildin HAVE_OPENCL is already defined through cvconfig.h
+# extra dependencies for builtin code (OpenCL dir is required for extensions like cl_d3d11.h)
+# builtin HAVE_OPENCL is already defined through cvconfig.h
 list(APPEND __builtin_include_dirs "${__opencl_dirs}")
 
 # extra dependencies for

packages/xgboost/test_xgboost.py

@@ -231,7 +231,7 @@ def test_pandas_categorical(selenium):
     assert transformed.columns[0].min() == 0
 
     # test missing value
-    X = pd.DataFrame({"f0": ["a", "b", np.NaN]})
+    X = pd.DataFrame({"f0": ["a", "b", np.nan]})
     X["f0"] = X["f0"].astype("category")  # type: ignore[call-overload]
     arr, _, _ = xgb.data._transform_pandas_df(X, enable_categorical=True)
     assert not np.any(arr == -1.0)

src/tests/test_pyodide.py

@@ -1757,22 +1757,21 @@ def helper(selenium):
 )
 def test_runpython_filename(selenium, run_python):
     msg = selenium.run_js(
-        """
-        try {
-            %s(`
+        f"""
+        try {{
+            {run_python}(`
                 def f1():
                     f2()
 
                 def f2():
                     raise Exception("oops")
 
                 f1()
-            `, {filename: "a.py"});
-        } catch(e) {
+            `, {{filename: "a.py"}});
+        }} catch(e) {{
             return e.message
-        }
+        }}
         """
-        % run_python
     )
     expected = dedent(
         """

src/tests/test_streams.py

@@ -523,17 +523,16 @@ def test_custom_stdin_interrupts(selenium, method):
     from pyodide.code import run_js
 
     run_js(
-        """
+        f"""
         ib = new Int32Array(1);
         pyodide.setInterruptBuffer(ib);
-        pyodide.setStdin({
-            %s () {
+        pyodide.setStdin({{
+            {method} () {{
                 ib[0] = 2;
                 pyodide.checkInterrupt();
-            }
-        });
+            }}
+        }});
         """
-        % method
     )
     try:
         with pytest.raises(KeyboardInterrupt):
@@ -555,17 +554,16 @@ def test_custom_stdout_interrupts(selenium, method):
     from pyodide.code import run_js
 
     run_js(
-        """
+        f"""
         ib = new Int32Array(1);
         pyodide.setInterruptBuffer(ib);
-        pyodide.setStdout({
-            %s () {
+        pyodide.setStdout({{
+            {method} () {{
                 ib[0] = 2;
                 pyodide.checkInterrupt();
-            }
-        });
+            }}
+        }});
         """
-        % method
     )
     try:
         with pytest.raises(KeyboardInterrupt):

tools/bump_version.py

@@ -125,7 +125,7 @@ def parse_current_version(target: Target) -> str:
     match = target.pattern.search(content)
 
     if match is None:
-        raise ValueError(f"Unabled to detect version string: {target.file}")
+        raise ValueError(f"Unable to detect version string: {target.file}")
 
     return match.groupdict()["version"]