BB2-448 Create multi stage PR checks for continuous-integration/jenkins/pr-merge (#886)

* Remove Travis/TOX completely

- Remove .travis.yml and tox.ini files.
  Travis functionality is also being removed for
  BB2-449, so it makes sense to remove completely
  here.  However, BB2-449 will have to be released
  together with this PR.

BB2-448

* Rename Jenkins and Kubernetes POD config files

- Rename Kubernetes POD config file
  from cbc-run-integration-tests.yaml to cbc-pod-deployment-config.yml.

- Rename POD config file referrence and rename file
  Jenkinsfile.cbc-run-integration-tests to Jenkinsfile.cbc-run-multi-pr-checks

BB2-448

* Add unit tests stage to pipeline

- Add unit tests as a new stage in
  Jenkinsfiles/Jenkinsfile.cbc-run-multi-pr-checks

BB2-448

* Test notifyGithubStatus

* Unset ENV vars in runtests.py

- Unset ENV vars in runtests.py for unit type tests
  for DJANGO_USER_ID_ITERATIONS' and 'DJANGO_USER_ID_SALT'

BB2-448

* Add flake8 configuration file

* Add flake8 lint/style check stage to pipeline

- Add flake8 check as a new stage in
  Jenkinsfiles/Jenkinsfile.cbc-run-multi-pr-checks

BB2-448

* Add pip install for flake8 check

* Fix Jenkinsfile stage ordering

* Fix flake8 stage with venv

* Fix Jenkinsfile issue

* Update requirements for require-hashes and DEV

- In Makefile, update the "reqs-download" option to download
  package files for both requirements.txt and requirements.dev.txt
  in to the ./vendor/ directory.

- In Makefile, update the "reqs-install" and "reqs-install-dev" options
  to require checking the hashes via the --require-hashes option.

- Include extra DEV related packages under ./vendor/ directory.

- Remove "make reqs-install" since "make reqs-install-dev" will
  install all needed packages in Jenkinsfiles/Jenkinsfile.cbc-run-multi-pr-checks

BB2-448

* Remove require-hashes until after amz linux tests

Author: dtisza1

Diff for: .flake8

@@ -0,0 +1,4 @@
+[flake8]
+max-line-length = 130
+ignore = F403,F405,W503
+exclude = migrations,docs,examples,bluebutton-css,vendor,venv,*/management/*

Diff for: .travis.yml

@@ -2,7 +2,7 @@ pipeline {
   agent {
     kubernetes {
       defaultContainer "bb2-cbc-build"
-      yamlFile "Jenkinsfiles/cbc-run-integration-tests.yaml"
+      yamlFile "Jenkinsfiles/cbc-pod-deployment-config.yaml"
     }
   }
 
@@ -24,29 +24,46 @@ pipeline {
   }
 
   stages {
-    stage("Copy FHIR cert and key") {
+    stage("SETUP FHIR cert and key") {
       steps {
         writeFile(file: "${env.DJANGO_FHIR_CERTSTORE}/certstore/ca.cert.pem", text: readFile(env.FHIR_CERT))
         writeFile(file: "${env.DJANGO_FHIR_CERTSTORE}/certstore/ca.key.nocrypt.pem", text: readFile(env.FHIR_KEY))
       }
     }
 
-    stage("Create venv and install dependencies") {
+    stage("INSTALL Python Packages") {
       steps {
         sh """
           python -m venv venv
           . venv/bin/activate
-          pip install -r requirements/requirements.txt --no-index --find-links ./vendor/
-          pip install sqlparse
+          make reqs-install-dev
         """
       }
     }
 
-    stage("Run integration tests") {
+    stage("CHECK Flake8 Python Lint/Style") {
       steps{
         sh """
-        . venv/bin/activate
-        python runtests.py --integration apps.integration_tests.integration_test_fhir_resources.IntegrationTestFhirApiResources
+          . venv/bin/activate
+          flake8
+        """
+      }
+    }
+
+    stage("RUN Django Unit Tests") {
+      steps{
+        sh """
+          . venv/bin/activate
+          python runtests.py
+        """
+      }
+    }
+
+    stage("RUN integration tests") {
+      steps{
+        sh """
+          . venv/bin/activate
+          python runtests.py --integration apps.integration_tests.integration_test_fhir_resources.IntegrationTestFhirApiResources
         """
       }
     }

Diff for: Jenkinsfiles/Jenkinsfile.cbc-run-integration-tests renamed to Jenkinsfiles/Jenkinsfile.cbc-run-multi-pr-checks

@@ -2,11 +2,12 @@ reqs-compile:
 	pip-compile --generate-hashes --output-file requirements/requirements.txt requirements/requirements.in
 	pip-compile --generate-hashes --output-file requirements/requirements.dev.txt requirements/requirements.dev.in
 
+# Note: requirements.dev.txt includes packages from requirements.txt also.
 reqs-download:
-	pip download -r requirements/requirements.txt --dest vendor --platform linux_x86_64 --no-deps
+	pip download -r requirements/requirements.dev.txt --dest vendor --platform linux_x86_64 --no-deps
 
 reqs-install:
 	pip install -r requirements/requirements.txt --no-index --find-links ./vendor/
 
 reqs-install-dev:
-	pip install -r requirements/requirements.dev.txt
+	pip install -r requirements/requirements.dev.txt --no-index --find-links ./vendor/

Diff for: Jenkinsfiles/cbc-run-integration-tests.yaml renamed to Jenkinsfiles/cbc-pod-deployment-config.yaml

@@ -48,7 +48,8 @@
     # Unset ENV variables for Django unit type tests so default values get set.
     for env_var in ['FHIR_URL', 'DJANGO_MEDICARE_LOGIN_URI',
                     'DJANGO_SLS_USERINFO_ENDPOINT', 'DJANGO_SLS_TOKEN_ENDPOINT',
-                    'DJANGO_FHIR_CERTSTORE', 'DATABASES_CUSTOM', 'DJANGO_LOG_JSON_FORMAT_PRETTY']:
+                    'DJANGO_FHIR_CERTSTORE', 'DATABASES_CUSTOM', 'DJANGO_LOG_JSON_FORMAT_PRETTY',
+                    'DJANGO_USER_ID_ITERATIONS', 'DJANGO_USER_ID_SALT']:
         if env_var in os.environ:
             del os.environ[env_var]