Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MERIT download logic is faulty in cases where download domain is right on the edge of a merit download block #161

Open
wknoben opened this issue Sep 1, 2022 · 0 comments
Open

MERIT download logic is faulty in cases where download domain is right on the edge of a merit download block #161

wknoben opened this issue Sep 1, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wknoben
Copy link
Collaborator

wknoben commented Sep 1, 2022

CWARHM/3b_parameters/MERIT_Hydro_DEM/1_download/download_merit_hydro_adjusted_elevation.py

Lines 104 to 105 in ae3e501

dl_lons = dl_lon_all[(domain_min_lon < lon_right_edge) & (domain_max_lon > lon_left_edge)]
dl_lats = dl_lat_all[(domain_min_lat < lat_top_edge) & (domain_max_lat > lat_bottom_edge)]

should likely be:

dl_lons = dl_lon_all[(domain_min_lon < lon_right_edge) & (domain_max_lon >= lon_left_edge)]
dl_lats = dl_lat_all[(domain_min_lat < lat_top_edge) & (domain_max_lat >= lat_bottom_edge)]

Needs a bit more testing.
@wknoben wknoben added bug Something isn't working good first issue Good for newcomers labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wknoben