New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid that batchDepth is smaller than zero #2

Open

astrocreep opened this issue Jan 31, 2025 · 0 comments

astrocreep commented Jan 31, 2025

Currently there is no check if there is really an active batch.

endBatch()
// batchDepth is now -1
// should do nothing

startBatch()
// batchDepth is now 0 and nothing is batched
// should be 1 and batching should happen.

endBatch()
// batchDepth is now -1 again
// should be 0 and call processEffectNotifications

Will not trigger updates after the final end batch. It will trigger them on startBatch, what is not the expected result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment