Removed workaround for #25 and #26 (now they are properly fixed

by avoiding reentrant graphic updates in graphic events callbacks)

Author: BrunoLevy

geogram

@@ -1021,10 +1021,6 @@ namespace OGF {
     MeshGrobPaintRect::MeshGrobPaintRect(
         ToolsManager* parent
     ) : MeshGrobPaintTool(parent) {
-        // This active flag is needed, else sometimes when one
-        // picks a GUI item, this triggers a release() event
-        // and creates a selection.
-        active_ = false;
     }
 
     void MeshGrobPaintRect::grab(const RayPick& p_ndc) {
@@ -1036,7 +1032,6 @@ namespace OGF {
 
         MeshGrobPaintTool::grab(p_ndc);
         p_ = ndc_to_dc(p_ndc.p_ndc);
-        active_ = true;
     }
 
     void MeshGrobPaintRect::drag(const RayPick& p_ndc) {
@@ -1046,10 +1041,6 @@ namespace OGF {
 	    return;
 	}
 
-        if(!active_) {
-            return;
-        }
-
         // Draw selection rectangle in overlay
         vec2 q = ndc_to_dc(p_ndc.p_ndc);
         rendering_context()->overlay().clear();
@@ -1085,11 +1076,6 @@ namespace OGF {
 	    return;
 	}
 
-        if(!active_) {
-            return;
-        }
-
-        active_ = false;
         vec2 q = ndc_to_dc(raypick.p_ndc);
         index_t px = index_t(p_.x);
         index_t py = index_t(p_.y);
@@ -1284,7 +1270,6 @@ namespace OGF {
 
         MeshGrobPaintTool::grab(raypick);
         selection_.push_back(ndc_to_dc(raypick.p_ndc));
-        active_ = true;
     }
 
     void MeshGrobPaintFreeform::drag(const RayPick& raypick) {
@@ -1294,9 +1279,6 @@ namespace OGF {
 	    return;
 	}
 
-        if(!active_) {
-            return;
-        }
         if(length(raypick.p_ndc - latest_ndc_) <= 10.0/1024.0) {
             return ;
         }
@@ -1318,11 +1300,6 @@ namespace OGF {
 	    return;
 	}
 
-        if(!active_) {
-            return;
-        }
-        active_ = false;
-
         index_t x0,y0,width,height;
         {
             double minx =  Numeric::max_float64();

src/lib/OGF/mesh_gfx/tools/mesh_grob_paint_tools.cpp

@@ -294,8 +294,6 @@ namespace OGF {
             index_t x0, index_t y0, index_t x1, index_t y1,
             Image* mask = nullptr
         );
-
-        bool active_;
         vec2 p_;
     };