Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll actions rendered in the wrong position in Edge 16 with RTL #159

Open
ppaskaris-d2l opened this issue Mar 13, 2018 · 6 comments
Open

Comments

@ppaskaris-d2l
Copy link
Contributor

ppaskaris-d2l commented Mar 13, 2018

In Microsoft Edge 16, in RTL, the sticky scroll actions are rendered in the wrong position. Specifically, they are rendered far to the right. The click targets are still positioned in the correct place, and the buttons do work as if they were rendered in the correct place.

<d2l-offscreen> is likely causing the issue to manifest:

Microsoft is aware of this issue and it appears to be a defect in their position: sticky; implementation.

@awikkerink
Copy link
Contributor

scroll-wrapper right-action

@awikkerink
Copy link
Contributor

@ppaskaris-d2l Thanks for doing this!

@ppaskaris-d2l
Copy link
Contributor Author

My pleasure! Sorry it was so rough for me to get the PR up to spec: it was basically a crash course in Daylight development.

Does this need to get release tagged before it can be added to BSI? I've a build locally just against the sha1 and it's beautiful.

@awikkerink
Copy link
Contributor

awikkerink commented Mar 13, 2018

Yes. You can bump it with npm version minor -m '(chore) bump version %s'

--edit But you don't have access to the repo? I can bump it.

@ppaskaris-d2l
Copy link
Contributor Author

I sure do not have access. Also, given that this is a bower package, isn't the version just a git-tag?

@awikkerink
Copy link
Contributor

awikkerink commented Mar 13, 2018

It is, but npm version also updates the package.json. I suppose it technically doesn't matter.

--edit nvm. We aren't using the version in package.json. I must be thinking of another project. I'll bump the git tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants