-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New WYSIWYG Editor: Share feedback & issues here #5245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ssddanbrown I would love to test it out, but I don't see yet any v24.10 release. |
@AvrumFeldman I'm just preparing its release now, for later this week (Created this so I could link to it from the update blogpost) |
Bookstack v24.10 released a few hours age and i unfortunately found a bug. Not sure if i had to post it here so ill post the link: #5249. |
Hi @ssddanbrown
I have also a question. Here's my code which I have used to modify the buttons: window.addEventListener("editor-tinymce::pre-init", (event) => {
const mceConfig = event.detail.config;
mceConfig.toolbar += " clearformat";
});
window.addEventListener("editor-tinymce::setup", (event) => {
const editor = event.detail.editor;
// Registriere das Icon mit validiertem SVG-Code
editor.ui.registry.addIcon(
"clearformaticon",
`<svg xmlns="http://www.w3.org/2000/svg"
width="24" height="24"
viewBox="0 0 496 496" xml:space="preserve">
fill="currentColor">
<path style="fill:#DD3E95;" d="M363.6,224V37.6C363.6,15.2,348.4,0,326,0H169.2c-22.4,0-37.6,15.2-37.6,37.6V224H363.6z"/>
<path style="fill:#BC086B;" d="M131.6,224h232V37.6C363.6,15.2,348.4,0,326,0H179.6"/>
<path style="fill:#2F96C9;" d="M131.6,272v186.4c0,22.4,23.2,37.6,45.6,37.6h149.6c22.4,0,37.6-15.2,37.6-37.6V272H131.6z"/>
<path style="fill:#207EB7;" d="M181.2,272l-49.6,186.4c0,22.4,23.2,37.6,45.6,37.6h149.6c22.4,0,37.6-15.2,37.6-37.6V272H181.2z"/>
<rect x="131.6" y="224" style="fill:#FFFFFF;" width="232" height="48"/>
<rect x="179.6" y="224" style="fill:#EFE6D8;" width="184" height="48"/>
<rect x="275.6" y="224" style="fill:#DDD3C5;" width="88" height="48"/>
<path style="fill:#095A91;" d="M179.6,272v224H326c22.4,0,37.6-15.2,37.6-37.6V272H179.6z"/>
<path style="fill:#044D7F;" d="M179.6,496H326c22.4,0,37.6-15.2,37.6-37.6V272"/>
<path style="fill:#911743;" d="M326,0H179.6v224h184V37.6C363.6,15.2,348.4,0,326,0z"/>
<polyline style="fill:#7F113E;" points="179.6,224 363.6,224 363.6,40 "/>
</svg>`
);
// Füge den Button hinzu
editor.ui.registry.addButton("clearformat", {
tooltip: "Formatierung entfernen (Ctrl/Cmd+Alt+U)",
icon: "clearformaticon",
onAction() {
editor.execCommand("RemoveFormat");
},
});
// Shortcuts hinzufügen
editor.addShortcut("ctrl+alt+u", "Formatierung entfernen", () => {
editor.execCommand("RemoveFormat");
});
// macOS
editor.addShortcut("meta+alt+u", "Formatierung entfernen", () => {
editor.execCommand("RemoveFormat");
});
}); |
@thegatesdev Thanks, lists are deceivingly complex 😅 Do you have a use-case/need for empty (space only) lists? @miracuruzrh Thanks! Had meant to note the lack of dark mode support but had forgotten by release! In regard to customizations/hacking, that's not something I'm considering right now in the earlier alpha/beta stages, but maybe it's something that can be discussed in the later stages toward when it's becoming the default, when internals/development has stabilised a bit. |
One use-case I can think of is when using numbered lists, when writing content from elsewhere that is already numbered, you can skip one entry (for later) by leaving it empty and preserving the numbering for the next.
I realized that while testing, best of luck with the implementation 🙏🏼 🥲 |
Hi @ssddanbrown |
Hi Dan, you may already be aware of this regarding collapsible blocks:
Additionally (These may be better suited as a dedicated feature requests), I've really been enjoying Confluence's latest editor whereby you can use Markdown shortcuts as you type.
Separately, the |
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks @beanaroo, have added those notes regarding collapse block issues. @beanaroo @ttepatti I consider new functionality outside the scope of this issue, and in regard to markdown based auto-conversion/formatting specifically, this has been touched upon previously in #2025 and my feelings are much the same. Would be more open to making that kind of thing possible via an unofficial hack, once the editor is more stable/mature. |
When switching from the old editor or from the markdown editor, task lists are converted to bullet lists. Switching them to a task list is easy (simply click the task list button again and it converts) but this would be a nice improvement. |
|
When clicking a menu button on the new WYSIWYG editor, if you leave any of either the button or the menu that opens, it all closes out. The old editor, it would stay put until either you clicked off of the menu or you clicked on an item in the menu. I cannot take a screencap or I would. |
Yes! That is it. I don't see your comment in the thread though. Not sure
how to see it. That is it though.
…On Thu, Mar 13, 2025 at 9:47 AM Tim ***@***.***> wrote:
@Hallsie <https://github.com/Hallsie> I think this is what you mean:
(Oops, give me a second, wrong encoding)
https://github.com/user-attachments/assets/e649d075-2758-4714-908d-5f9baabd807d
—
Reply to this email directly, view it on GitHub
<#5245 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGBRIX3PFBEGJWXJ6F6HNWL2UGD6LAVCNFSM6AAAAABPP2LD3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRRGMZDCMZXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: thegatesdev]*thegatesdev* left a comment
(BookStackApp/BookStack#5245)
<#5245 (comment)>
@Hallsie <https://github.com/Hallsie> I think this is what you mean:
(Oops, give me a second, wrong encoding)
https://github.com/user-attachments/assets/e649d075-2758-4714-908d-5f9baabd807d
—
Reply to this email directly, view it on GitHub
<#5245 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGBRIX3PFBEGJWXJ6F6HNWL2UGD6LAVCNFSM6AAAAABPP2LD3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRRGMZDCMZXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Haha, sorry the first part of the screen recording was broken for me, and I couldn't fix it in time. That is why I deleted the comment. I'll record it again today. |
Here we go: DisappearingMenuExample.mp4 |
It's great to see auto linking is back - is there any chance we can get automatic insertion of images from links? It used to be a feature of the last editor, and the process now to insert an external hotlinked image is a little convoluted (insert an uploaded image from the gallery first, then change the URL). Being able to paste the link right in would help. |
Sorry, got a bit behind in keeping up with additions. Thanks @imlwhite, @thegatesdev, @Hallsie, @3ma-TSI, @dallyger for reporting this. All added to the list to address. @dallyger In regards to saving, I've noticed this too sometimes during testing but never been able to nail down replication. I'll have a full review of the saving mechanics. @imlwhite I wasn't even aware that was a feature! I've added to to the list, but I may come up with an alternative middle ground, to make using external links easier, but without the auto-convert, just to avoid users being potentially misled thinking that the image is somehow uploaded safely into BookStack (like it would be for pasting actual image data/files). |
This is a thread specifically to collect feedback regarding issues and limitations of the new WYSIWYG editor, introduced in BookStack v24.10.
This below list will be continuously updated from feedback to form a full listing to be worked on.
Please only report issues where not already in this list.
Generally our goal is to match the existing TinyMCE based editor as close as possible.
Known Issues
Cat https://example.com
)Related PRs
The text was updated successfully, but these errors were encountered: