Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #8

Open
jameswilson opened this issue May 31, 2018 · 1 comment
Open

Add tests #8

jameswilson opened this issue May 31, 2018 · 1 comment
Assignees

Comments

@jameswilson
Copy link
Member

Any changes we make are really hard to test the impact without having an example to test with.

I suggest we create a sub-folder called test containing its own streamlined package.json, gulpfile.js, and a sass folder containing some simple sass rules.

As for how to properly write the tests themselves, I'm not sure. Maybe we should copy the generated contents of the css folder to other folder names like css-gulp-sass css-gulp-sass-no-sourcemaps etc and write javascript that recursively compares the generated output in css from running gulp sass and gulp sass --no-sourcemaps with these other folders.

Unfortunately though this wouldn't necessarily allow us to test things like purposeful linting failures.

It also wouldn't test to confirm BrowserSync commands work, so we'd need a separate test for that. Not sure how we'd write that either, to confirm that the watch command doesn't fail, and confirm that it starts browsersync (not sure how to detect the port).

@balintk any suggestions on how we might go about testing that the tasks and command line options?

@jameswilson
Copy link
Member Author

For now. I'm going to commit and merge the test folder, we'll suffice with manual eyeball tests.

jameswilson added a commit that referenced this issue May 31, 2018
Add test folder with basic sass test. #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants