Upgrade soap dependency, and improve APIs

Author: IonicaBizau

example/index.js

@@ -5,16 +5,7 @@ const BrokerBin = require("../lib");
 (async () => {
 
     // Initialize the BrokerBin
-    const bbClient = new BrokerBin({
-        username: process.env.BROKERBIN_USERNAME
-      , password: process.env.BROKERBIN_PASSWORD
-      , soap_key: process.env.BROKERBIN_SOAP_KEY
-      , soap_uri: process.env.BROKERBIN_SOAP_URI
-      , public_key: process.env.BROKERBIN_PUBLIC_KEY
-    })
-
-    // Authenticate
-    await bbClient.authenticate()
+    const bbClient = new BrokerBin()
 
     // Run a search
     const results = await bbClient.search("F238F", {

lib/index.js

@@ -14,15 +14,21 @@ class BrokerBin {
      * @function
      * @param {Object} auth An object containing the following data:
      *
-     *    - `username` (String): The BrokerBin username.
-     *    - `password` (String): The BrokerBin password.
-     *    - `soap_key` (String): The BrokerBin soap key.
-     *    - `soap_uri` (String): The BrokerBin soap uri.
-     *    - `public_key` (String): The BrokerBin public key.
+     *    - `username` (String): The BrokerBin username (or ENV variable: `BROKERBIN_USERNAME`)
+     *    - `password` (String): The BrokerBin password (or ENV variable: `BROKERBIN_PASSWORD`)
+     *    - `soap_key` (String): The BrokerBin soap key (or ENV variable: `BROKERBIN_SOAP_KEY`)
+     *    - `soap_uri` (String): The BrokerBin soap uri (or ENV variable: `BROKERBIN_SOAP_URI`)
+     *    - `public_key` (String): The BrokerBin public key (or ENV variable: `BROKERBIN_PUBLIC_KEY`)
      *
      * @return {Number} Return description.
      */
-    constructor (auth) {
+    constructor (auth = {}) {
+
+        auth.username = auth.username || process.env.BROKERBIN_USERNAME
+        auth.password = auth.password || process.env.BROKERBIN_PASSWORD
+        auth.soap_key = auth.soap_key || process.env.BROKERBIN_SOAP_KEY
+        auth.soap_uri = auth.soap_uri || process.env.BROKERBIN_SOAP_URI
+        auth.public_key = auth.public_key || process.env.BROKERBIN_PUBLIC_KEY
 
         const {
             username
@@ -84,6 +90,9 @@ class BrokerBin {
      * @return {Promise} Resolves with the results.
      */
     async search (reqPart, reqOptions) {
+        if (!this.soapUid) {
+            await this.authenticate()
+        }
         return new Promise((resolve, reject) => {
             reqOptions.uid = this.soapUid
             this.soapClient.Search({
@@ -96,7 +105,7 @@ class BrokerBin {
                 try {
                     res = phpunserialize(res.resParam.$value)
                 } catch (e) {
-                    // TODO This fails silently
+                    // TODO This fails quite silently
                     console.error(e)
                     res = {}
                     res.resultset = [{

package.json

@@ -42,6 +42,6 @@
   "dependencies": {
     "mcrypt": "^0.1.17",
     "phpunserialize": "^1.0.1",
-    "soap": "^0.36.0"
+    "soap": "^0.43.0"
   }
-}
+}