Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update home charts #732

Merged
merged 7 commits into from
Mar 24, 2025
Merged

feat: update home charts #732

merged 7 commits into from
Mar 24, 2025

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Feb 24, 2025

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

  • Show last 30 days instead of 15 days of Gas Expenditure on Home page
  • Replace Daily Transactions by Blobs per Rollup in Home page

Related Issue (Optional)

Closes #616

Screenshots

image

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ❌ Failed (Inspect) Mar 10, 2025 1:15pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 1:15pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 1:15pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 1:15pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 1:15pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 1:15pm

Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: cb06309

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@blobscan/api Minor
@blobscan/web Minor
@blobscan/rest-api-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 37.33333% with 47 lines in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (f855bdf) to head (cb06309).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...kages/api/src/routers/stats/getRollupDailyStats.ts 32.85% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   88.80%   88.39%   -0.42%     
==========================================
  Files         163      165       +2     
  Lines       11090    11136      +46     
  Branches     1210     1157      -53     
==========================================
- Hits         9849     9844       -5     
- Misses       1241     1292      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Feb 24, 2025

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to rename the chart titles. I would just rename the charts to:

  • Blob Gas Price
  • "Rollup Blob Usage" or "Blobs per Rollup" as you mention

Also for Blob Gas Price can you actually try a line chart and also 90 days? I believe it would look better.

@xFJA xFJA requested a review from PabloCastellano March 10, 2025 13:15
@PJColombo PJColombo merged commit b6217e8 into main Mar 24, 2025
11 of 14 checks passed
@PJColombo PJColombo deleted the update-home-charts branch March 24, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change charts shown in homepage
3 participants