Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display decoded data for Optimism blobs #608

Merged
merged 17 commits into from
Nov 12, 2024
Merged

Fix display decoded data for Optimism blobs #608

merged 17 commits into from
Nov 12, 2024

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Fix display decoded data for Optimism blobs

Related Issue

Closes #554

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 45da81a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 4:03am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 4:03am
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 4:03am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 4:03am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 4:03am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 4:03am

Copy link
Contributor

github-actions bot commented Oct 28, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 332.27 KB (🔴 +86.65 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 332.51 KB 95.00%
/stats 348 KB 680.27 KB 194.36%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 353.07 KB 685.33 KB 195.81% (🟢 -4.65%)
/address/[address] 28.54 KB 360.8 KB 103.09% (🟢 -4.34%)
/blob/[hash] 29.22 KB 361.49 KB 103.28% (🟢 -3.77%)
/blobs 79.05 KB 411.32 KB 117.52% (🟡 +13.21%)
/block/[id] 14.9 KB 347.17 KB 99.19% (🟢 -3.99%)
/blocks 76.75 KB 409.02 KB 116.86% (🟡 +13.20%)
/tx/[hash] 17.22 KB 349.49 KB 99.85% (🟡 +1.14%)
/txs 76.25 KB 408.52 KB 116.72% (🟡 +11.19%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 62.62626% with 37 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ba1d783). Learn more about missing BASE report.
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
packages/api/src/utils/autocompleteBlockHash.ts 24.13% 22 Missing ⚠️
packages/api/src/blob-parse/optimism.ts 41.17% 10 Missing ⚠️
...ackages/api/src/blob-parse/parse-decoded-fields.ts 86.11% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage        ?   88.87%           
=======================================
  Files           ?      158           
  Lines           ?    10614           
  Branches        ?     1192           
=======================================
  Hits            ?     9433           
  Misses          ?     1181           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. I think we can improve it a little bit more.

I left a few request changes.

@PabloCastellano
Copy link
Member

Tests need to be updated

Copy link
Member

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only nitpick is the name chosen for the function, which sounds too technical, but feel free to merge

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luis-herasme Can we add a changeset?

@PabloCastellano PabloCastellano merged commit 4226258 into main Nov 12, 2024
7 of 12 checks passed
@PabloCastellano PabloCastellano deleted the fix-op branch November 12, 2024 04:34
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display decoded data for Optimism blobs
4 participants