Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealing with failed downloads #10

Open
23b opened this issue Jul 14, 2020 · 3 comments
Open

Dealing with failed downloads #10

23b opened this issue Jul 14, 2020 · 3 comments

Comments

@23b
Copy link

23b commented Jul 14, 2020

Sometimes image-files get created without any content.
For now I had to weed out any corrupted files (<1KB) and re-run the entire process to fill in the failed downloads.
Would be sweet to have a post download check if filesize is anything reasonable (e.g. >1KB)
If not retry the download.
@23b
Copy link
Author

23b commented Jul 15, 2020

The content of those failed files is actually ascii text saying:

<html>
<head><title>502 Bad Gateway</title></head>
<body bgcolor="white">
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx</center>
</body>
</html>

@Blickfeldkurier
Copy link
Owner

That happens if soup.io is broken while the image gets downloaded.
Maybe we should add the retry code we use to fetch the page to the download code as well.
What happens if we exceed max retries? The same as in this version? Mark it in the JSON instead of showing just the 502?

@Locke
Copy link
Contributor

Locke commented Jul 16, 2020

It looks like this could come handy: https://stackoverflow.com/a/35504626/2565743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Locke @Blickfeldkurier @23b