Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf Generation fails on Master #1887

Open
cmprmsd opened this issue Feb 12, 2025 · 1 comment
Open

Protobuf Generation fails on Master #1887

cmprmsd opened this issue Feb 12, 2025 · 1 comment

Comments

@cmprmsd
Copy link
Contributor

cmprmsd commented Feb 12, 2025

Describe the bug
When trying to obfuscate or change protobuf definitions or even just regenerate the protobuf files with make pb the server is not able to generate implants any more.

To Reproduce
Steps to reproduce the behavior:

  1. checkout master
  2. make pb
  3. start sliver-server in debug mode with dlv
  4. generate --http ....
  5. Error

Expected behavior
The implants should generate at least without any changes. I did check through the file and it seems some of the logic has been changed in the *.pb.go files after generating with make pb.

Screenshots
The breakpoint where panic happens:

Image

[*] Generating new windows/amd64 implant binary
panic: interface conversion: ast.Expr is *ast.CallExpr, not *ast.CompositeLit

Desktop (please complete the following information):

  • OS: Linux
  • Version git master 2f486be

Additional context
Changes include e.g. the import and use of unsafe

Image

@cmprmsd
Copy link
Contributor Author

cmprmsd commented Feb 12, 2025

The issue might be my version of protobuf. I'll change to the same version and see if that fixes it.

from tag:1.5.42:

// 	protoc-gen-go v1.27.1
// 	protoc        v4.22.2

vs

// 	protoc-gen-go v1.36.5
// 	protoc        v5.29.2

Edit: Manually downloading a lower version of protoc helped. I think though, that "make pb" should be integrated into the build process of the docker image as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant