Skip to content

Commit 2da0c7c

Browse files
authored
Merge pull request #442 from BeAPI/fix-rtl-functions
fix rtl functions with all language codes
2 parents 41166b8 + f4e836c commit 2da0c7c

File tree

3 files changed

+41
-23
lines changed

3 files changed

+41
-23
lines changed

src/js/utils/isRTL.js

+15-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,17 @@
11
export default function isRTL() {
2-
return (
3-
document.documentElement.dir === 'rtl' ||
4-
document.documentElement.lang === 'ar' ||
5-
document.documentElement.lang === 'iw'
6-
)
2+
const rtlLanguages = [
3+
'ar', // Arabic
4+
'fa', // Persian (Farsi)
5+
'he', // Hebrew (modern code)
6+
'iw', // Hebrew (legacy code)
7+
'ur', // Urdu
8+
'ps', // Pashto
9+
'sd', // Sindhi
10+
'ug', // Uyghur
11+
'dv', // Divehi (Maldivian)
12+
'ku', // Kurdish (Sorani)
13+
'yi', // Yiddish
14+
]
15+
16+
return document.documentElement.dir === 'rtl' || rtlLanguages.includes(document.documentElement.lang)
717
}

src/scss/02-tools/_m-rtl.scss

+24-8
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Support for rtl text, explicit support for Arabic and Hebrew
2+
* Support for rtl text, explicit support for all RTL languages
33
*
44
* @author Cédric Andrietti
55
*
@@ -13,17 +13,33 @@
1313
*
1414
*/
1515

16+
$rtl-languages: (
17+
"ar", // Arabic
18+
"fa", // Persian (Farsi)
19+
"he", // Hebrew (modern code)
20+
"iw", // Hebrew (legacy code)
21+
"ur", // Urdu
22+
"ps", // Pashto
23+
"sd", // Sindhi
24+
"ug", // Uyghur
25+
"dv", // Divehi (Maldivian)
26+
"ku", // Kurdish (Sorani)
27+
"yi" // Yiddish
28+
);
29+
1630
@mixin rtl {
17-
*[dir="rtl"] &,
18-
:root:lang(ar) &,
19-
:root:lang(iw) & {
20-
@content;
31+
@each $lang in $rtl-languages {
32+
*[dir="rtl"] &,
33+
:root:lang(#{$lang}) & {
34+
@content;
35+
}
2136
}
2237
}
2338

2439
@mixin set-rtl-direction {
25-
&:lang(ar),
26-
&:lang(iw) {
27-
direction: rtl;
40+
@each $lang in $rtl-languages {
41+
&:lang(#{$lang}) {
42+
direction: rtl;
43+
}
2844
}
2945
}

src/scss/08-template-parts/_header.scss

+2-10
Original file line numberDiff line numberDiff line change
@@ -260,11 +260,7 @@
260260
width: column(9);
261261

262262
> div {
263-
text-align: right;
264-
265-
@include rtl {
266-
text-align: left;
267-
}
263+
text-align: end;
268264
}
269265
}
270266

@@ -277,11 +273,7 @@
277273

278274
> li {
279275
display: inline;
280-
text-align: left;
281-
282-
@include rtl {
283-
text-align: right;
284-
}
276+
text-align: start;
285277

286278
+ li {
287279
margin-inline-start: 28px;

0 commit comments

Comments
 (0)