Allow updating location stream settings #1664
Conversation
|
@TimHoogstrate PLMK if there is interest in merging this PR and I can clean it up. |
|
Dear @orkun1675, Thanks for your PR. We are looking forward to review this. Looks like an interesting addition. I'll do a quick review, try to do a little test and you can clean it up if possible. Kind regard, |
| @@ -275,8 +278,17 @@ public void startPositionUpdates( | |||
| }); | |||
| } | |||
|
|
|||
| @Override | |||
| public void updateLocationOptions(LocationOptions options) { | |||
| @Override | ||
| public void updateLocationOptions(LocationOptions options) { | ||
| this.locationOptions = options; | ||
| if (running) { |
There was a problem hiding this comment.
I think it is a good idea to notice the developer that the location updates could not be made. Due to .... Or skip keeping track if it is running at all and let the developer manage this. It will prevent errors.
| @@ -64,6 +66,16 @@ public void startPositionUpdates( | |||
| locationClient.startPositionUpdates(activity, positionChangedCallback, errorCallback); | |||
| } | |||
|
|
|||
| public boolean updateLocationOptions(LocationOptions options) { | |||
There was a problem hiding this comment.
@Nullable LocationOptions options
|
|
||
| private static GeolocationManager geolocationManagerInstance = null; | ||
| private static GeolocationManager geolocationManagerInstance = null; |
There was a problem hiding this comment.
@nullable annotation
| CLLocationManager *locationManager = [self getLocationManager]; | ||
| locationManager.desiredAccuracy = desiredAccuracy; | ||
| locationManager.distanceFilter = distanceFilter; | ||
| if (@available(iOS 6.0, macOS 10.15, *)) { |
There was a problem hiding this comment.
Do we need that @available(iOS 6.0 ?
| } | ||
|
|
||
| #if TARGET_OS_IOS | ||
| if (@available(iOS 9.0, macOS 11.0, *)) { |
There was a problem hiding this comment.
same here, do we need the @available(iOS 9.0, macOS 11.0, *)
|
I've tested this on iOS and Android (Pixel 7) en it seems to work as expected. |
|
The idea is to split up the PR in desperate PR's. Separate packages, platform interface and app facing package. If you need any help from us let us know. Kind regards, |
This PR allows updating the location stream after one is started. It adds a new API endpoint:
This endpoint allows plugin users to change settings, such as
distanceFilterorintervalDuration, without having to stop & start the stream. This is critical if the update is hapenning while the app is in the background since Android does not allow starting a location stream unless the app is in focus.Fixes #1569. Improved version of #1406.
If there is interest in merging this PR I will clean it up and send for review.
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.