Spec out integration of shipping notes

Author: davidlaprade

spec/mds/services/submit_order_spec.rb

@@ -3,6 +3,44 @@
 describe MDS::Services::SubmitOrder do
   subject { described_class.new(sample_credentials) }
 
+  describe '#builder' do
+    it 'adds shipping instructions to the XML when present in JSON' do
+      xml = subject.builder(sample_shipment).to_xml
+      expect( xml ).to match /OrderNotes/
+      expect( xml ).to match /MustShipBy/
+      expect( xml ).to match /NoShipBefore/
+    end
+    it 'does not add shipping notes to the XML when absent from JSON' do
+      shipment = sample_shipment.except(:shipping_notes, :must_ship_by, :no_ship_before)
+      xml = subject.builder( shipment ).to_xml
+      expect( xml ).to_not match /OrderNotes/
+      expect( xml ).to_not match /MustShipBy/
+      expect( xml ).to_not match /NoShipBefore/
+    end
+    [:shipping_notes, :must_ship_by, :no_ship_before].each do |key|
+      it "does not error when #{key} key is missing from JSON" do
+        expect{ subject.builder sample_shipment.delete_if {|k| k == key }
+        }.to_not raise_exception
+      end
+      it "does not error when #{key} is blank in JSON" do
+        expect{ subject.builder sample_shipment.merge(key => "")
+        }.to_not raise_exception
+      end
+    end
+    it "errors when must_ship_by date is invalid" do
+      expect{ subject.builder sample_shipment.merge(must_ship_by: "2015-08-51T00:00:00")
+      }.to raise_exception("Error setting up shipping instructions: invalid date")
+    end
+    it "replaces ampersands in shipping instructions" do
+      xml = subject.builder(sample_shipment.merge(shipping_notes: "Pick & pack")).to_xml
+      expect( xml ).to match /Pick and pack/
+    end
+    it "errors when shipping_notes are too long" do
+      expect{ subject.builder sample_shipment.merge(shipping_notes: "A"*501)
+      }.to raise_exception
+    end
+  end
+
   describe '#query' do
     it "allows for internation characters" do
       VCR.use_cassette("submit_internation_order") do

spec/support/sample_objects.rb

@@ -14,6 +14,9 @@ def sample_shipment(number = "R#{rand(999999)}")
     "email"=>"[email protected]",
     "currency"=>"USD",
     "placed_on"=>"2014-02-03T17:29:15.219Z",
+    "shipping_notes"=>"Please fit in large box",
+    "no_ship_before"=>"2015-08-01T00:00:00+00:00",
+    "must_ship_by"=>"2015-08-25T00:00:00+00:00",
     "totals"=>
     {"item"=>200,
      "adjustment"=>20,